src/PNaClTranslator.cpp - Issue 1435363002: Merge fixed alloca stack adjustments into the prolog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/PNaClTranslator.cpp

Issue 1435363002: Merge fixed alloca stack adjustments into the prolog (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Final code review comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/PNaClTranslator.cpp

diff --git a/src/PNaClTranslator.cpp b/src/PNaClTranslator.cpp

index 755971d3df5c898ec88d1addedd5ff8cbd2ab892..cff46e7b7f687c013f93ba08e135badb3171dd35 100644

--- a/src/PNaClTranslator.cpp

+++ b/src/PNaClTranslator.cpp

@@ -2626,7 +2626,7 @@ void FunctionParser::ProcessRecord() {

return;

}

CurrentNode->appendInst(Ice::InstAlloca::create(

- Func.get(), ByteCount, Alignment, getNextInstVar(PtrTy)));

+ Func.get(), getNextInstVar(PtrTy), ByteCount, Alignment));

return;

}

case naclbitc::FUNC_CODE_INST_LOAD: {

« no previous file with comments | « src/IceTargetLoweringX86Base.h ('k') | tests_lit/llvm2ice_tests/alloc.ll » ('j') | no next file with comments »