src/IceConverter.cpp - Issue 1435363002: Merge fixed alloca stack adjustments into the prolog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceConverter.cpp

Issue 1435363002: Merge fixed alloca stack adjustments into the prolog (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Final code review comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceConverter.cpp

diff --git a/src/IceConverter.cpp b/src/IceConverter.cpp

index 89fa2e3618242c8f7c1ee49212efac90c85b4548..34bdcb9976b313d15f9b2fc816a4e92f29d851f0 100644

--- a/src/IceConverter.cpp

+++ b/src/IceConverter.cpp

@@ -586,7 +586,7 @@ private:

uint32_t Align = Inst->getAlignment();

Ice::Variable *Dest = mapValueToIceVar(Inst, Ice::getPointerType());

- return Ice::InstAlloca::create(Func.get(), ByteCount, Align, Dest);

+ return Ice::InstAlloca::create(Func.get(), Dest, ByteCount, Align);

}

Ice::Inst *convertUnreachableInstruction(const UnreachableInst * /*Inst*/) {

« no previous file with comments | « src/IceCfg.cpp ('k') | src/IceInst.h » ('j') | no next file with comments »