src/IceTargetLowering.cpp - Issue 1435363002: Merge fixed alloca stack adjustments into the prolog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLowering.cpp

Issue 1435363002: Merge fixed alloca stack adjustments into the prolog (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: One more code review fix Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLowering.cpp

diff --git a/src/IceTargetLowering.cpp b/src/IceTargetLowering.cpp

index 0ee0afa2301929fa5e2596a709f0db2bd03e3886..4f09a6bcbb86f311f19f82eccf482c0563802f95 100644

--- a/src/IceTargetLowering.cpp

+++ b/src/IceTargetLowering.cpp

@@ -363,7 +363,9 @@ void TargetLowering::getVarStackSlotParams(

VarList SpilledVariables;

for (Variable *Var : Variables) {

if (Var->hasReg()) {

- RegsUsed[Var->getRegNum()] = true;

+ // Rematerializable uses of stack/frame do not count as uses for spilling.

Jim Stichnoth 2015/11/16 22:47:18 stack/frame pointer

+ if (!Var->isRematerializable())

+ RegsUsed[Var->getRegNum()] = true;

continue;

}

// An argument either does not need a stack slot (if passed in a register)

« no previous file with comments | « src/IceTargetLowering.h ('k') | src/IceTargetLoweringARM32.h » ('j') | no next file with comments »