Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1435343002: GN: Tweak chrome_public_apk_tmpl to allow extra proguard_configs (Closed)

Created:
5 years, 1 month ago by agrieve
Modified:
5 years, 1 month ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@proguard-3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Tweak chrome_public_apk_tmpl to allow extra proguard_configs BUG=554513 Committed: https://crrev.com/203833423f5a1febbdb90bdd8166a8335521e3e4 Cr-Commit-Position: refs/heads/master@{#359348}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/android/chrome_public_apk_tmpl.gni View 1 chunk +8 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
agrieve
5 years, 1 month ago (2015-11-12 17:57:45 UTC) #2
Yaron
lgtm
5 years, 1 month ago (2015-11-12 17:59:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435343002/1
5 years, 1 month ago (2015-11-12 18:17:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 18:51:27 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:08:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/203833423f5a1febbdb90bdd8166a8335521e3e4
Cr-Commit-Position: refs/heads/master@{#359348}

Powered by Google App Engine
This is Rietveld 408576698