Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1435333008: GN: asset_location -> android_assets() for html_viewer (Closed)

Created:
5 years, 1 month ago by agrieve
Modified:
5 years ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, pkotwicz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: asset_location -> android_assets() for html_viewer Necessitated adding a "write_asset_list" arg for creating the assets_list file. BUG=547162 Committed: https://crrev.com/e3f13c3bbf9ccc16c64870e0a79c3b85daf5d1be Cr-Commit-Position: refs/heads/master@{#361366}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebaswe #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -63 lines) Patch
M build/android/gyp/apkbuilder.py View 1 2 3 chunks +14 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 2 3 chunks +6 lines, -0 lines 0 comments Download
M build/config/android/rules.gni View 1 2 4 chunks +28 lines, -38 lines 0 comments Download
M components/html_viewer/BUILD.gn View 1 2 3 chunks +7 lines, -19 lines 0 comments Download
M testing/test.gni View 2 chunks +7 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (5 generated)
agrieve
sky@chromium.org: Please review changes in everywhere dpranke@chromium.org: Please review changes in testing/
5 years, 1 month ago (2015-11-17 03:11:24 UTC) #2
Dirk Pranke
lgtm
5 years, 1 month ago (2015-11-17 03:18:00 UTC) #4
sky
sky->brettw
5 years, 1 month ago (2015-11-17 18:23:54 UTC) #6
agrieve
On 2015/11/17 18:23:54, sky wrote: > sky->brettw bump
5 years, 1 month ago (2015-11-19 21:34:39 UTC) #7
brettw
lgtm
5 years, 1 month ago (2015-11-20 21:50:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435333008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435333008/40001
5 years ago (2015-11-24 14:51:43 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-24 16:44:44 UTC) #12
commit-bot: I haz the power
5 years ago (2015-11-24 16:45:57 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e3f13c3bbf9ccc16c64870e0a79c3b85daf5d1be
Cr-Commit-Position: refs/heads/master@{#361366}

Powered by Google App Engine
This is Rietveld 408576698