Refactor dependent code.

Refactor dependent code.

This simplifies the layout of dependent code array and optimizes it for sparse dependency groups.

BUG=chromium:554488
LOG=NO

Committed: https://crrev.com/4ef29b1adfefe32ee8ee09b5990dbd4340711620
Cr-Commit-Position: refs/heads/master@{#32170}

[ulan, 2015-11-19 09:58:15]

Description was changed from

==========
Refactor dependent code.

BUG=
==========

to

==========
Refactor dependent code.

This simplifies the layout of dependent code array and optimizes it for sparse
dependency groups.

BUG=chromium:554488
==========

[ulan, 2015-11-19 09:58:15]

ulan@chromium.org changed reviewers:
+ ishell@chromium.org

[ulan, 2015-11-19 09:58:22]

Description was changed from

==========
Refactor dependent code.

This simplifies the layout of dependent code array and optimizes it for sparse
dependency groups.

BUG=chromium:554488
==========

to

==========
Refactor dependent code.

This simplifies the layout of dependent code array and optimizes it for sparse
dependency groups.

BUG=chromium:554488
LOG=NO
==========

[ulan, 2015-11-19 09:58:30]

PTAL

[ulan, 2015-11-19 10:25:38]

The CQ bit was checked by ulan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-19 10:25:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1435313002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1435313002/80001

[commit-bot: I haz the power, 2015-11-19 10:47:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-19 10:47:21]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2015-11-20 12:35:32]

lgtm with nits.

https://codereview.chromium.org/1435313002/diff/80001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1435313002/diff/80001/src/objects.cc#newcode1...
src/objects.cc:13739: DCHECK_LE(this->group(), group);
I think this check is redundant, given that we have CHECK_EQ below.

Maybe put DCHECK_NE(0, this->length()) here instead.

https://codereview.chromium.org/1435313002/diff/80001/src/objects.cc#newcode1...
src/objects.cc:13764: DCHECK_LE(this->group(), group);
Ditto.

https://codereview.chromium.org/1435313002/diff/80001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/1435313002/diff/80001/src/objects.h#newcode5472
src/objects.h:5472: inline void set_flags(int flags);
I think the flags accessors should be private.

https://codereview.chromium.org/1435313002/diff/80001/src/objects.h#newcode5500
src/objects.h:5500: class GroupField : public BitField<int, 0, 3> {};
Please add this:
  STATIC_ASSERT(kGroupCount <= GroupField::kMax + 1);

[ulan, 2015-11-23 09:01:11]

Thanks.

https://codereview.chromium.org/1435313002/diff/80001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1435313002/diff/80001/src/objects.cc#newcode1...
src/objects.cc:13739: DCHECK_LE(this->group(), group);
On 2015/11/20 12:35:32, Igor Sheludko wrote:
> I think this check is redundant, given that we have CHECK_EQ below.
> 
> Maybe put DCHECK_NE(0, this->length()) here instead.

Removed, the length is dchecked when accessing the group().

https://codereview.chromium.org/1435313002/diff/80001/src/objects.cc#newcode1...
src/objects.cc:13764: DCHECK_LE(this->group(), group);
On 2015/11/20 12:35:32, Igor Sheludko wrote:
> Ditto.

Done.

https://codereview.chromium.org/1435313002/diff/80001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/1435313002/diff/80001/src/objects.h#newcode5472
src/objects.h:5472: inline void set_flags(int flags);
On 2015/11/20 12:35:32, Igor Sheludko wrote:
> I think the flags accessors should be private.

Done.

https://codereview.chromium.org/1435313002/diff/80001/src/objects.h#newcode5500
src/objects.h:5500: class GroupField : public BitField<int, 0, 3> {};
On 2015/11/20 12:35:32, Igor Sheludko wrote:
> Please add this:
>   STATIC_ASSERT(kGroupCount <= GroupField::kMax + 1);

Done.

[ulan, 2015-11-23 09:09:53]

The CQ bit was checked by ulan@chromium.org

[ulan, 2015-11-23 09:09:54]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/1435313002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-11-23 09:09:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1435313002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1435313002/120001

[commit-bot: I haz the power, 2015-11-23 09:12:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-23 09:12:08]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/7980)

[Jakob Kummerow, 2015-11-23 09:26:42]

jkummerow@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Jakob Kummerow, 2015-11-23 09:26:43]

src/crankshaft/ LGTM, haven't looked at the rest.

[ulan, 2015-11-23 09:29:03]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2015-11-23 09:29:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1435313002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1435313002/120001

[commit-bot: I haz the power, 2015-11-23 09:30:21]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-11-23 09:30:35]

Patchset 7 (id:??) landed as
https://crrev.com/4ef29b1adfefe32ee8ee09b5990dbd4340711620
Cr-Commit-Position: refs/heads/master@{#32170}