Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Side by Side Diff: components/crash/content/app/BUILD.gn

Issue 1435293002: GN: Add quotes when setting BUILD_ID from android_chrome_build_id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_android) { 5 if (is_android) {
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 } 7 }
8 8
9 source_set("lib") { 9 source_set("lib") {
10 sources = [ 10 sources = [
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 deps = [ 103 deps = [
104 ":lib", 104 ":lib",
105 "//base", 105 "//base",
106 "//base:base_static", 106 "//base:base_static",
107 "//components/crash/core/common", 107 "//components/crash/core/common",
108 "//content/public/common:content_descriptors", 108 "//content/public/common:content_descriptors",
109 "//content/public/common:result_codes", 109 "//content/public/common:result_codes",
110 ] 110 ]
111 111
112 if (is_android) { 112 if (is_android) {
113 defines += [ "CHROME_BUILD_ID=" + android_chrome_build_id ] 113 defines += [ "CHROME_BUILD_ID=\"$android_chrome_build_id\"" ]
114 } 114 }
115 115
116 if (is_win) { 116 if (is_win) {
117 deps += [ 117 deps += [
118 "//sandbox", 118 "//sandbox",
119 "//breakpad:breakpad_handler", 119 "//breakpad:breakpad_handler",
120 120
121 #'../breakpad/breakpad.gyp:breakpad_sender', TODO(GYP) 121 #'../breakpad/breakpad.gyp:breakpad_sender', TODO(GYP)
122 ] 122 ]
123 } else if (is_posix && !is_ios) { 123 } else if (is_posix && !is_ios) {
(...skipping 24 matching lines...) Expand all
148 deps += [ 148 deps += [
149 ":lib", 149 ":lib",
150 "//base", 150 "//base",
151 "//base:base_static", 151 "//base:base_static",
152 "//breakpad", 152 "//breakpad",
153 "//breakpad:client", 153 "//breakpad:client",
154 "//components/crash/core/common", 154 "//components/crash/core/common",
155 ] 155 ]
156 } 156 }
157 } 157 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698