Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: chrome/browser/ui/BUILD.gn

Issue 1435293002: GN: Add quotes when setting BUILD_ID from android_chrome_build_id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/crash/content/app/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/crypto.gni") 5 import("//build/config/crypto.gni")
6 import("//build/config/features.gni") 6 import("//build/config/features.gni")
7 import("//build/config/ui.gni") 7 import("//build/config/ui.gni")
8 8
9 gypi_values = exec_script("//build/gypi_to_gn.py", 9 gypi_values = exec_script("//build/gypi_to_gn.py",
10 [ rebase_path("../../chrome_browser_ui.gypi") ], 10 [ rebase_path("../../chrome_browser_ui.gypi") ],
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 ".", 317 ".",
318 "//chrome") 318 "//chrome")
319 } 319 }
320 320
321 if (is_android) { 321 if (is_android) {
322 deps += [ 322 deps += [
323 "//chrome/browser:jni_headers", 323 "//chrome/browser:jni_headers",
324 "//crypto:platform", 324 "//crypto:platform",
325 ] 325 ]
326 326
327 defines += [ "CHROME_BUILD_ID=" + android_chrome_build_id ] 327 defines += [ "CHROME_BUILD_ID=\"$android_chrome_build_id\"" ]
328 328
329 if (!use_aura) { 329 if (!use_aura) {
330 sources += 330 sources +=
331 rebase_path(gypi_values.chrome_browser_ui_android_non_aura_sources, 331 rebase_path(gypi_values.chrome_browser_ui_android_non_aura_sources,
332 ".", 332 ".",
333 "//chrome") 333 "//chrome")
334 deps += [ "//components/web_contents_delegate_android" ] 334 deps += [ "//components/web_contents_delegate_android" ]
335 deps -= [ "//ui/events" ] 335 deps -= [ "//ui/events" ]
336 } 336 }
337 } 337 }
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
590 "//chrome/browser", 590 "//chrome/browser",
591 "//content/public/browser", 591 "//content/public/browser",
592 "//content/public/common", 592 "//content/public/common",
593 "//content/test:test_support", 593 "//content/test:test_support",
594 "//net:test_support", 594 "//net:test_support",
595 "//skia", 595 "//skia",
596 "//testing/gtest", 596 "//testing/gtest",
597 "//ui/base", 597 "//ui/base",
598 ] 598 ]
599 } 599 }
OLDNEW
« no previous file with comments | « no previous file | components/crash/content/app/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698