Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 1435283003: Subzero: Fix a crash in mem operand dumping. (Closed)

Created:
5 years, 1 month ago by Jim Stichnoth
Modified:
5 years, 1 month ago
Reviewers:
Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix a crash in mem operand dumping. getOffset() was being dereferenced even when it was nullptr. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=8099e9acb2557fcf30b509d743697e4cc8a6ce35

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M src/IceInstX8632.cpp View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jim Stichnoth
5 years, 1 month ago (2015-11-12 17:20:32 UTC) #3
Karl
lgtm
5 years, 1 month ago (2015-11-12 17:41:00 UTC) #4
Jim Stichnoth
5 years, 1 month ago (2015-11-12 18:26:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8099e9acb2557fcf30b509d743697e4cc8a6ce35 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698