src/messages.cc - Issue 1435273002: Fix name shown by devtools for subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/messages.cc

Issue 1435273002: Fix name shown by devtools for subclasses. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/messages.cc

diff --git a/src/messages.cc b/src/messages.cc

index 27ee8e43345ea289c63299174daef9c77f30533c..66e096b92a585903565000669c79a6608a551bc8 100644

--- a/src/messages.cc

+++ b/src/messages.cc

@@ -416,7 +416,7 @@ MaybeHandle<String> ErrorToStringHelper::Stringify(Isolate* isolate,

if (internal_error_lookup.IsFound() &&

!ShadowsInternalError(isolate, &name_lookup, &internal_error_lookup)) {

Handle<JSObject> holder = internal_error_lookup.GetHolder<JSObject>();

- name = Handle<String>(holder->constructor_name());

+ name = JSReceiver::GetConstructorName(holder);

} else {

ASSIGN_RETURN_ON_EXCEPTION(

isolate, name,

« no previous file with comments | « src/factory.cc ('k') | src/objects.h » ('j') | src/objects.cc » ('J')