src/api.cc - Issue 1435273002: Fix name shown by devtools for subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 1435273002: Fix name shown by devtools for subclasses. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 5d4c9c0c415ac558747dfa55b25b19a02c9187b4..95504e7ca42289b7ea18723afe0fd825af03b821 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -3846,7 +3846,7 @@ Local<String> v8::Object::ObjectProtoToString() {

Local<String> v8::Object::GetConstructorName() {

auto self = Utils::OpenHandle(this);

- i::Handle<i::String> name(self->constructor_name());

+ i::Handle<i::String> name = i::JSReceiver::GetConstructorName(self);

return Utils::ToLocal(name);

}

« no previous file with comments | « no previous file | src/factory.cc » ('j') | src/objects.cc » ('J')