Fix name shown by devtools for subclasses.

Fix name shown by devtools for subclasses.

This replaces internal GetConstructorName with toStringTag, .constructor's name
and class_name. This entirely changes how the name is computed for use in
devtools.

BUG=chromium:529177
LOG=n

Committed: https://crrev.com/469675ee3f137970158305957a76615d33ff253c
Cr-Commit-Position: refs/heads/master@{#32374}

[Toon Verwaest, 2015-11-12 12:03:25]

verwaest@chromium.org changed reviewers:
+ adamk@chromium.org, cbruni@chromium.org, pfeldman@chromium.org

[Toon Verwaest, 2015-11-12 12:03:25]

PTAL

Adding this CL "breaks" some existing LayoutTests. I tried very hard to keep the
behavior close to what we have now; but more uniform with
Object.prototype.toString (although without side-effects). I'd like to get
feedback especially from DevTools devs whether they are ok with this change.

With this change, the code at
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
becomes unnecessary as it is already done internally (although differently).

[Camillo Bruni, 2015-11-12 12:43:08]

LGTM, very minor nit

https://codereview.chromium.org/1435273002/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1435273002/diff/20001/src/objects.cc#newcode733
src/objects.cc:733: if (it->isolate()->context() != nullptr && it->HasAccess())
continue;
nit: maybe add a comment that you check for the missing context because of dev
tools? (other ->HasAccess calls don't do so)

https://codereview.chromium.org/1435273002/diff/20001/src/objects.cc#newcode2158
src/objects.cc:2158: String* inferred_name =
constructor->shared()->inferred_name();
I would have expected to check for the inferred_name first... but that's
probably valid only for anonymous functions which don't have a name in the first
place.

https://codereview.chromium.org/1435273002/diff/20001/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-crbug-523308.js (right):

https://codereview.chromium.org/1435273002/diff/20001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-crbug-523308.js:9: assertEquals("Array:
reference_error is not defined",
actually makes more sense this way...

[Toon Verwaest, 2015-11-25 16:29:35]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-11-25 16:29:35]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/1435273002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-11-25 16:29:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1435273002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1435273002/60001

[commit-bot: I haz the power, 2015-11-25 16:47:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-25 16:47:03]

Try jobs failed on following builders:
  v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/11220)

[Toon Verwaest, 2015-11-26 09:48:32]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-11-26 09:48:33]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/1435273002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2015-11-26 09:48:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1435273002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1435273002/80001

[commit-bot: I haz the power, 2015-11-26 10:23:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 10:23:25]

Try jobs failed on following builders:
  v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/11255)

[Toon Verwaest, 2015-11-27 12:32:09]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-11-27 12:32:10]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/1435273002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-11-27 12:32:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1435273002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1435273002/100001

[commit-bot: I haz the power, 2015-11-27 13:10:07]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-11-27 13:10:31]

Description was changed from

==========
Fix name shown by devtools for subclasses.

This replaces internal GetConstructorName with toStringTag, .constructor's name
and class_name. This entirely changes how the name is computed for use in
devtools.

BUG=chromium:529177
LOG=n
==========

to

==========
Fix name shown by devtools for subclasses.

This replaces internal GetConstructorName with toStringTag, .constructor's name
and class_name. This entirely changes how the name is computed for use in
devtools.

BUG=chromium:529177
LOG=n

Committed: https://crrev.com/469675ee3f137970158305957a76615d33ff253c
Cr-Commit-Position: refs/heads/master@{#32374}
==========

[commit-bot: I haz the power, 2015-11-27 13:10:32]

Patchset 6 (id:??) landed as
https://crrev.com/469675ee3f137970158305957a76615d33ff253c
Cr-Commit-Position: refs/heads/master@{#32374}