Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1435263002: Oilpan: account for DocumentThreadableLoader::m_document back ref. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: account for DocumentThreadableLoader::m_document back ref. R=haraken BUG=553613 Committed: https://crrev.com/7dd9d71a302d3633d451c37efd3615075bc2b805 Cr-Commit-Position: refs/heads/master@{#360025}

Patch Set 1 #

Total comments: 2

Patch Set 2 : use WeakPersistent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -15 lines) Patch
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 1 10 chunks +20 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sof
5 years, 1 month ago (2015-11-12 10:53:39 UTC) #2
haraken
https://codereview.chromium.org/1435263002/diff/1/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h File third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h (right): https://codereview.chromium.org/1435263002/diff/1/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h#newcode153 third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h:153: RawPtrWillBeUntracedMember<Document> m_document; So this should be WeakPersistent if it's ...
5 years, 1 month ago (2015-11-12 14:23:54 UTC) #4
sof
https://codereview.chromium.org/1435263002/diff/1/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h File third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h (right): https://codereview.chromium.org/1435263002/diff/1/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h#newcode153 third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h:153: RawPtrWillBeUntracedMember<Document> m_document; On 2015/11/12 14:23:54, haraken wrote: > > ...
5 years, 1 month ago (2015-11-16 21:16:18 UTC) #5
haraken
On 2015/11/16 21:16:18, sof wrote: > https://codereview.chromium.org/1435263002/diff/1/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h > File third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h (right): > > https://codereview.chromium.org/1435263002/diff/1/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h#newcode153 > ...
5 years, 1 month ago (2015-11-16 23:27:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435263002/20001
5 years, 1 month ago (2015-11-17 06:19:35 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-17 06:48:34 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 06:49:27 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7dd9d71a302d3633d451c37efd3615075bc2b805
Cr-Commit-Position: refs/heads/master@{#360025}

Powered by Google App Engine
This is Rietveld 408576698