VideoPlayer: Fix accessibility issues.

ui/file_manager/video_player/js/video_player.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @param {!HTMLElement} playerContainer Main container.
  * @param {!HTMLElement} videoContainer Container for the video element.
  * @param {!HTMLElement} controlsContainer Container for video controls.
  * @constructor
  * @struct
  * @extends {VideoControls}
  */
 function FullWindowVideoControls(
     playerContainer, videoContainer, controlsContainer) {
   VideoControls.call(this,
       controlsContainer,
       this.onPlaybackError_.wrap(this),
-      loadTimeData.getString.wrap(loadTimeData),
       this.toggleFullScreen_.wrap(this),
       videoContainer);
 
   this.playerContainer_ = playerContainer;
   this.decodeErrorOccured = false;
 
   this.casting = false;
 
   this.updateStyle();
   window.addEventListener('resize', this.updateStyle.wrap(this));
   var currentWindow = chrome.app.window.current();
   currentWindow.onFullscreened.addListener(
-      this.onFullScreenChanged_.bind(this, true));
+      this.onFullScreenChanged.bind(this, true));
   currentWindow.onRestored.addListener(
-      this.onFullScreenChanged_.bind(this, false));
+      this.onFullScreenChanged.bind(this, false));
   document.addEventListener('keydown', function(e) {
     switch (util.getKeyModifiers(e) + e.keyIdentifier) {
       // Handle debug shortcut keys.
       case 'Ctrl-Shift-U+0049': // Ctrl+Shift+I
         chrome.fileManagerPrivate.openInspector('normal');
         break;
       case 'Ctrl-Shift-U+004A': // Ctrl+Shift+J
         chrome.fileManagerPrivate.openInspector('console');
         break;
       case 'Ctrl-Shift-U+0043': // Ctrl+Shift+C
         chrome.fileManagerPrivate.openInspector('element');
         break;
       case 'Ctrl-Shift-U+0042': // Ctrl+Shift+B
         chrome.fileManagerPrivate.openInspector('background');
         break;
 
       case 'U+0020': // Space
       case 'MediaPlayPause':
-        this.togglePlayStateWithFeedback();
+        if (!e.target.classList.contains('menu-button'))
+          this.togglePlayStateWithFeedback();
         break;
       case 'U+001B': // Escape
         util.toggleFullScreen(
             chrome.app.window.current(),
             false);  // Leave the full screen mode.
         break;
       case 'Right':
       case 'MediaNextTrack':
         player.advance_(1);
         break;
@@ skipping 50 matching lines @@
   return this.inactivityWatcher_;
 };
 
 /**
  * Displays error message.
  *
  * @param {string} message Message id.
  */
 FullWindowVideoControls.prototype.showErrorMessage = function(message) {
   var errorBanner = getRequiredElement('error');
-  errorBanner.textContent = loadTimeData.getString(message);
+  errorBanner.textContent = str(message);
   errorBanner.setAttribute('visible', 'true');
 
   // The window is hidden if the video has not loaded yet.
   chrome.app.window.current().show();
 };
 
 /**
  * Handles playback (decoder) errors.
  * @param {MediaError} error Error object.
  * @private
@@ skipping 27 matching lines @@
 /**
  * Toggles the full screen mode.
  * @private
  */
 FullWindowVideoControls.prototype.toggleFullScreen_ = function() {
   var appWindow = chrome.app.window.current();
   util.toggleFullScreen(appWindow, !util.isFullScreen(appWindow));
 };
 
 /**
- * Updates video control when the window is fullscreened or restored.
- * @param {boolean} fullscreen True if the window gets fullscreened.
- * @private
- */
-FullWindowVideoControls.prototype.onFullScreenChanged_ = function(fullscreen) {
-  if (fullscreen) {
-    this.playerContainer_.setAttribute('fullscreen', '');
-  } else {
-    this.playerContainer_.removeAttribute('fullscreen');
-  }
-};
-
-/**
  * Media completion handler.
  */
 FullWindowVideoControls.prototype.onMediaComplete = function() {
   VideoControls.prototype.onMediaComplete.apply(this, arguments);
   if (!this.getMedia().loop)
     player.advance_(1);
 };
 
 /**
  * Video Player
@@ skipping 380 matching lines @@
   if (this.currentCast_) {
     var currentCastAvailable = casts.some(function(cast) {
       return this.currentCast_.label === cast.label;
     }.wrap(this));
 
     if (!currentCastAvailable)
       this.onCurrentCastDisappear_();
   }
 
   var item = new cr.ui.MenuItem();
-  item.label = loadTimeData.getString('VIDEO_PLAYER_PLAY_THIS_COMPUTER');
+  item.label = str('VIDEO_PLAYER_PLAY_THIS_COMPUTER');
   item.setAttribute('aria-label', item.label);
   item.castLabel = '';
   item.addEventListener('activate', this.onCastSelected_.wrap(this, null));
   menu.appendChild(item);
 
   for (var i = 0; i < casts.length; i++) {
     var item = new cr.ui.MenuItem();
     item.label = casts[i].friendlyName;
     item.setAttribute('aria-label', item.label);
     item.castLabel = casts[i].label;
@@ skipping 82 matching lines @@
   return new Promise(function(fulfill, reject) {
     util.URLsToEntries(window.appState.items, function(entries) {
       metrics.recordOpenVideoPlayerAction();
       metrics.recordNumberOfOpenedFiles(entries.length);
 
       player.prepare(entries);
       player.playFirstVideo(player, fulfill);
     }.wrap());
   }.wrap());
 }.wrap());