Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1435253002: VideoPlayer: Fix accessibility issues. (Closed)

Created:
5 years, 1 month ago by fukino
Modified:
5 years, 1 month ago
Reviewers:
mtomasz, yawano
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VideoPlayer: Fix accessibility issues. This CL is video-player part of https://codereview.chromium.org/1415953006/. As we decided to punt audio player's redesign, this CL includes changes only for video player. This includes: - Make each control focusable. - Implement blue outline for focused-by-keyboard buttons. - Add aria-label for buttons and sliders. - Extracted common behaviors of icon buttons as files-icon-button. BUG=551267, 533604 TEST=manually tested using ChromeVox. Committed: https://crrev.com/e658ee09f499f70c2bbb5589acaf4b35f6bd13d9 Cr-Commit-Position: refs/heads/master@{#359300}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -41 lines) Patch
M chrome/app/chromeos_strings.grdp View 2 chunks +32 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 3 chunks +24 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/foreground/elements/files_icon_button.html View 1 chunk +61 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/foreground/elements/files_icon_button.js View 1 chunk +29 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/manifest.json View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager_resources.grd View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/file_manager/video_player/css/media_controls.css View 4 chunks +14 lines, -9 lines 0 comments Download
M ui/file_manager/video_player/js/media_controls.js View 13 chunks +58 lines, -13 lines 0 comments Download
M ui/file_manager/video_player/js/video_player.js View 6 chunks +6 lines, -19 lines 0 comments Download
M ui/file_manager/video_player/video_player.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
fukino
mtomasz@: PTAL at chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc. yawano@: PTAL at others. Thank you!
5 years, 1 month ago (2015-11-12 09:33:19 UTC) #3
mtomasz
lgtm for strings
5 years, 1 month ago (2015-11-12 09:55:10 UTC) #4
yawano
lgtm. Thank you!
5 years, 1 month ago (2015-11-12 10:15:44 UTC) #5
fukino
Thank you!
5 years, 1 month ago (2015-11-12 10:38:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435253002/1
5 years, 1 month ago (2015-11-12 10:38:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 10:42:21 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:06:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e658ee09f499f70c2bbb5589acaf4b35f6bd13d9
Cr-Commit-Position: refs/heads/master@{#359300}

Powered by Google App Engine
This is Rietveld 408576698