Re-implements start_with_url.* benchmarks as start_with_url2.* using TBM

tools/perf/page_sets/startup_pages.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 from telemetry.page import page as page_module
+from telemetry.page import shared_page_state
 from telemetry import story
 
 
+class BrowserStartupSharedState(shared_page_state.SharedPageState):
+  """Shared state that restarts the browser for every single story.
+  """
+
+  def __init__(self, test, finder_options, story_set):
+    super(BrowserStartupSharedState, self).__init__(
+        test, finder_options, story_set)
+
+  def DidRunStory(self, results):
+    super(BrowserStartupSharedState, self).DidRunStory(results)
+    self._StopBrowser()
+
 class StartedPage(page_module.Page):
 
   def __init__(self, url, startup_url, page_set):
     super(StartedPage, self).__init__(
         url=url, page_set=page_set, startup_url=startup_url)
     self.archive_data_file = 'data/startup_pages.json'
 
   def RunNavigateSteps(self, action_runner):
     action_runner.Wait(10)
 
@@ skipping 14 matching lines @@
         archive_data_file='data/startup_pages.json',
         cloud_storage_bucket=story.PARTNER_BUCKET)
 
     # Typical page.
     self.AddStory(StartedPage('about:blank', 'about:blank', self))
     # Typical page.
     self.AddStory(StartedPage('http://bbc.co.uk', 'http://bbc.co.uk', self))
     # Horribly complex page - stress test!
     self.AddStory(StartedPage(
         'http://kapook.com', 'http://kapook.com', self))
+
+
+class StartedPageTBM(page_module.Page):
+
+  def __init__(self, url, page_set):
+    super(StartedPageTBM, self).__init__(
+        url=url, page_set=page_set, startup_url=url,
+        shared_page_state_class=BrowserStartupSharedState)
+    self.archive_data_file = 'data/startup_pages.json'
+
+  def RunNavigateSteps(self, action_runner):
+    # Do not call super.RunNavigateSteps() to not reload the page that has
+    # already been opened with startup_url.
+
+    # It is still not clear why we would need to wait 10s here. It has been

[eakuefner, 2015/11/17 16:51:52]

Put this text in the bug and replace this comment with something like

# TODO(gabadie): Get rid of this (crbug.com/555504)

Then, when you get around to figuring out whether it's a problem, you can either
remove the comment, or remove both the comment and the code :)

I'm definitely interested in seeing this happen soon, by the way, since saving
10 seconds per page per bot per run will add up in a big way.

[gabadie, 2015/11/17 18:14:23]

Done.

+    # here since the begining (bf5c7d375e881e8d7fa8b7e36f8b87587751ae84). Its
+    # purpose was to make sure the low priority task in charge of outputing the
+    # the histogram values we were interested in, was executed before stoping
+    # the browser. We might be able to get ride of it (crbug.com/555504).
+    action_runner.Wait(10)
+
+  def RunPageInteractions(self, action_runner):
+    self.RunNavigateSteps(action_runner)
+
+
+class StartupPagesPageSetTBM(story.StorySet):

[eakuefner, 2015/11/17 16:51:52]

Seems like you need to record this page set using record_wpr, and upload the
recording to cloud storage (JSON and sha1 should be part of this CL):
https://www.chromium.org/developers/telemetry/record_a_page_set

[eakuefner, 2015/11/17 17:54:02]

Whoops, since you're pointing to an archive_data_file that already exists for
the pages, you don't need to rerecord.

+
+  """ Pages for testing starting Chrome with a URL.
+  Note that this file can't be used with record_wpr, since record_wpr requires
+  a true navigate step, which we do not want for startup testing. Instead use
+  record_wpr startup_pages_record to record data for this test.
+  """
+
+  def __init__(self):
+    super(StartupPagesPageSetTBM, self).__init__(
+        archive_data_file='data/startup_pages.json',
+        cloud_storage_bucket=story.PARTNER_BUCKET)
+
+    # Typical page.
+    self.AddStory(StartedPageTBM('about:blank', self))
+    # Typical page.
+    self.AddStory(StartedPageTBM('http://bbc.co.uk', self))
+    # Horribly complex page - stress test!
+    self.AddStory(StartedPageTBM('http://kapook.com', self))