Re-implements start_with_url.* benchmarks as start_with_url2.* using TBM

tools/perf/page_sets/startup_pages.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 from telemetry.page import page as page_module
+from telemetry.page import shared_page_state
 from telemetry import story
 
 
+class BrowserStartupSharedState(shared_page_state.SharedPageState):
+  """Shared state that restarts the browser for every single story.
+  """

[eakuefner, 2015/11/18 18:39:53]

nit: looks like this can fit on the previous line

[gabadie, 2015/11/18 19:16:31]

Done.

+
+  def __init__(self, test, finder_options, story_set):
+    super(BrowserStartupSharedState, self).__init__(
+        test, finder_options, story_set)
+
+  def DidRunStory(self, results):
+    super(BrowserStartupSharedState, self).DidRunStory(results)
+    self._StopBrowser()
+

[eakuefner, 2015/11/18 18:39:53]

nit: two lines between top-level definitions

[gabadie, 2015/11/18 19:16:31]

Done.

 class StartedPage(page_module.Page):
 
   def __init__(self, url, startup_url, page_set):
     super(StartedPage, self).__init__(
         url=url, page_set=page_set, startup_url=startup_url)
     self.archive_data_file = 'data/startup_pages.json'
 
   def RunNavigateSteps(self, action_runner):
     action_runner.Wait(10)
 
@@ skipping 14 matching lines @@
         archive_data_file='data/startup_pages.json',
         cloud_storage_bucket=story.PARTNER_BUCKET)
 
     # Typical page.
     self.AddStory(StartedPage('about:blank', 'about:blank', self))
     # Typical page.
     self.AddStory(StartedPage('http://bbc.co.uk', 'http://bbc.co.uk', self))
     # Horribly complex page - stress test!
     self.AddStory(StartedPage(
         'http://kapook.com', 'http://kapook.com', self))
+
+
+class StartedPageTBM(page_module.Page):
+
+  def __init__(self, url, page_set):
+    super(StartedPageTBM, self).__init__(
+        url=url, page_set=page_set, startup_url=url,
+        shared_page_state_class=BrowserStartupSharedState)
+    self.archive_data_file = 'data/startup_pages.json'
+
+  def RunNavigateSteps(self, action_runner):
+    # Do not call super.RunNavigateSteps() to not reload the page that has
+    # already been opened with startup_url.
+
+    # TODO(gabadie): Get rid of this (crbug.com/555504)
+    action_runner.Wait(10)
+
+  def RunPageInteractions(self, action_runner):
+    self.RunNavigateSteps(action_runner)
+
+
+class StartupPagesPageSetTBM(story.StorySet):
+
+  """ Pages for testing starting Chrome with a URL.

[eakuefner, 2015/11/18 18:39:53]

nit: no space between """ and Pages. Newline after first line of docstring.

[gabadie, 2015/11/18 19:16:31]

Done.

+  Note that this file can't be used with record_wpr, since record_wpr requires
+  a true navigate step, which we do not want for startup testing. Instead use
+  record_wpr startup_pages_record to record data for this test.
+  """
+
+  def __init__(self):
+    super(StartupPagesPageSetTBM, self).__init__(
+        archive_data_file='data/startup_pages.json',
+        cloud_storage_bucket=story.PARTNER_BUCKET)
+
+    # Typical page.
+    self.AddStory(StartedPageTBM('about:blank', self))
+    # Typical page.
+    self.AddStory(StartedPageTBM('http://bbc.co.uk', self))
+    # Horribly complex page - stress test!
+    self.AddStory(StartedPageTBM('http://kapook.com', self))