Issue 143523006: Fix GOMA_DIR on android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 143523006: Fix GOMA_DIR on android. (Closed)

Created:
6 years, 11 months ago by Nico

Modified:
6 years, 11 months ago

Reviewers:
Isaac (away)

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix GOMA_DIR on android. The DEFINES was too late, by this time DEFINES already got exported as GYP_DEFINES BUG=none TEST=set GOMA_DIR=$HOME/goma, . build/android/envsetup.sh, android_gyp, check that out/Release/build.ninja contains goma line TBR=ilevy@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246062

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	build/android/envsetup.sh	View		1 chunk	+0 lines, -6 lines	0 comments	Download
	M	build/android/envsetup_functions.sh	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/143523006/1

6 years, 11 months ago (2014-01-21 17:33:57 UTC) #1

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages