Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Side by Side Diff: src/hydrogen-instructions.h

Issue 143523002: Fix representation requirement in HReturn. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen-instructions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1563 matching lines...) Expand 10 before | Expand all | Expand 10 after
1574 virtual bool IsDeletable() const V8_OVERRIDE { return true; } 1574 virtual bool IsDeletable() const V8_OVERRIDE { return true; }
1575 }; 1575 };
1576 1576
1577 1577
1578 class HReturn V8_FINAL : public HTemplateControlInstruction<0, 3> { 1578 class HReturn V8_FINAL : public HTemplateControlInstruction<0, 3> {
1579 public: 1579 public:
1580 DECLARE_INSTRUCTION_WITH_CONTEXT_FACTORY_P2(HReturn, HValue*, HValue*); 1580 DECLARE_INSTRUCTION_WITH_CONTEXT_FACTORY_P2(HReturn, HValue*, HValue*);
1581 DECLARE_INSTRUCTION_WITH_CONTEXT_FACTORY_P1(HReturn, HValue*); 1581 DECLARE_INSTRUCTION_WITH_CONTEXT_FACTORY_P1(HReturn, HValue*);
1582 1582
1583 virtual Representation RequiredInputRepresentation(int index) V8_OVERRIDE { 1583 virtual Representation RequiredInputRepresentation(int index) V8_OVERRIDE {
1584 // TODO(titzer): require an Int32 input for faster returns.
1585 if (index == 2) return Representation::Smi();
1584 return Representation::Tagged(); 1586 return Representation::Tagged();
1585 } 1587 }
1586 1588
1587 virtual void PrintDataTo(StringStream* stream) V8_OVERRIDE; 1589 virtual void PrintDataTo(StringStream* stream) V8_OVERRIDE;
1588 1590
1589 HValue* value() { return OperandAt(0); } 1591 HValue* value() { return OperandAt(0); }
1590 HValue* context() { return OperandAt(1); } 1592 HValue* context() { return OperandAt(1); }
1591 HValue* parameter_count() { return OperandAt(2); } 1593 HValue* parameter_count() { return OperandAt(2); }
1592 1594
1593 DECLARE_CONCRETE_INSTRUCTION(Return) 1595 DECLARE_CONCRETE_INSTRUCTION(Return)
(...skipping 5959 matching lines...) Expand 10 before | Expand all | Expand 10 after
7553 virtual bool IsDeletable() const V8_OVERRIDE { return true; } 7555 virtual bool IsDeletable() const V8_OVERRIDE { return true; }
7554 }; 7556 };
7555 7557
7556 7558
7557 #undef DECLARE_INSTRUCTION 7559 #undef DECLARE_INSTRUCTION
7558 #undef DECLARE_CONCRETE_INSTRUCTION 7560 #undef DECLARE_CONCRETE_INSTRUCTION
7559 7561
7560 } } // namespace v8::internal 7562 } } // namespace v8::internal
7561 7563
7562 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 7564 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698