Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1435223003: Revert of AudioPlayer: Start playing a track when play icon on the track list is clicked. (Closed)

Created:
5 years, 1 month ago by fukino
Modified:
5 years, 1 month ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of AudioPlayer: Start playing a track when play icon on the track list is clicked. (patchset #3 id:40001 of https://codereview.chromium.org/1431523003/ ) Reason for revert: We decided to punt redesign of audio player to M49. Original issue's description: > AudioPlayer: Start playing a track when play icon on the track list is clicked. > > Clicking a track usually changes tracks but doesn't change the play state. (play / pause) > With this CL, clicking play icon which is shown on hover will force start playing the track. > > BUG=488229 > TEST=manually > > Committed: https://crrev.com/38df7abb0c59ef1ea11cc183ae151b6c235ff4c9 > Cr-Commit-Position: refs/heads/master@{#357071} TBR=yawano@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=488229 Committed: https://crrev.com/f44eb9893d0b73bdb1501012bb46922c32b310bb Cr-Commit-Position: refs/heads/master@{#359285}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -29 lines) Patch
M ui/file_manager/audio_player/elements/audio_player.html View 1 chunk +1 line, -2 lines 0 comments Download
M ui/file_manager/audio_player/elements/audio_player.js View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/file_manager/audio_player/elements/track_list.css View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/file_manager/audio_player/elements/track_list.js View 3 chunks +6 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fukino
Created Revert of AudioPlayer: Start playing a track when play icon on the track list ...
5 years, 1 month ago (2015-11-12 08:30:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435223003/1
5 years, 1 month ago (2015-11-12 08:30:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435223003/1
5 years, 1 month ago (2015-11-12 08:31:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 08:32:00 UTC) #4
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:06:00 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f44eb9893d0b73bdb1501012bb46922c32b310bb
Cr-Commit-Position: refs/heads/master@{#359285}

Powered by Google App Engine
This is Rietveld 408576698