Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1610)

Unified Diff: runtime/lib/typeddata.dart

Issue 14352013: Use identical instead of === and !identical instead of !== (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/typeddata.dart
===================================================================
--- runtime/lib/typeddata.dart (revision 21688)
+++ runtime/lib/typeddata.dart (working copy)
@@ -2882,7 +2882,7 @@
_throwRangeError(byteOffset, length);
}
var result = _typeddata._getInt16(_offset + byteOffset);
- if (endian === Endianness.HOST_ENDIAN) {
+ if (identical(endian, Endianness.HOST_ENDIAN)) {
return result;
}
return _toEndianInt16(result, endian._littleEndian);
@@ -2894,7 +2894,7 @@
_throwRangeError(byteOffset, length);
}
var set_value = _toInt16(value);
- if (endian !== Endianness.HOST_ENDIAN) {
+ if (!identical(endian, Endianness.HOST_ENDIAN)) {
set_value = _toEndianInt16(set_value, endian._littleEndian);
}
_typeddata._setInt16(_offset + byteOffset, set_value);
@@ -2905,7 +2905,7 @@
_throwRangeError(byteOffset, length);
}
var result = _typeddata._getUint16(_offset + byteOffset);
- if (endian === Endianness.HOST_ENDIAN) {
+ if (identical(endian, Endianness.HOST_ENDIAN)) {
return result;
}
return _toEndianUint16(result, endian._littleEndian);
@@ -2917,7 +2917,7 @@
_throwRangeError(byteOffset, length);
}
var set_value = _toUint16(value);
- if (endian !== Endianness.HOST_ENDIAN) {
+ if (!identical(endian, Endianness.HOST_ENDIAN)) {
set_value = _toEndianUint16(set_value, endian._littleEndian);
}
_typeddata._setUint16(_offset + byteOffset, set_value);
@@ -2928,7 +2928,7 @@
_throwRangeError(byteOffset, length);
}
var result = _typeddata._getInt32(_offset + byteOffset);
- if (endian === Endianness.HOST_ENDIAN) {
+ if (identical(endian, Endianness.HOST_ENDIAN)) {
return result;
}
return _toEndianInt32(result, endian._littleEndian);
@@ -2940,7 +2940,7 @@
_throwRangeError(byteOffset, length);
}
var set_value = _toInt32(value);
- if (endian !== Endianness.HOST_ENDIAN) {
+ if (!identical(endian, Endianness.HOST_ENDIAN)) {
set_value = _toEndianInt32(set_value, endian._littleEndian);
}
_typeddata._setInt32(_offset + byteOffset, set_value);
@@ -2951,7 +2951,7 @@
_throwRangeError(byteOffset, length);
}
var result = _typeddata._getUint32(_offset + byteOffset);
- if (endian === Endianness.HOST_ENDIAN) {
+ if (identical(endian, Endianness.HOST_ENDIAN)) {
return result;
}
return _toEndianUint32(result, endian._littleEndian);
@@ -2963,7 +2963,7 @@
_throwRangeError(byteOffset, length);
}
var set_value = _toUint32(value);
- if (endian !== Endianness.HOST_ENDIAN) {
+ if (!identical(endian, Endianness.HOST_ENDIAN)) {
set_value = _toEndianUint32(set_value, endian._littleEndian);
}
_typeddata._setUint32(_offset + byteOffset, set_value);
@@ -2974,7 +2974,7 @@
_throwRangeError(byteOffset, length);
}
var result = _typeddata._getInt64(_offset + byteOffset);
- if (endian === Endianness.HOST_ENDIAN) {
+ if (identical(endian, Endianness.HOST_ENDIAN)) {
return result;
}
return _toEndianInt64(result, endian._littleEndian);
@@ -2986,7 +2986,7 @@
_throwRangeError(byteOffset, length);
}
var set_value = _toInt64(value);
- if (endian !== Endianness.HOST_ENDIAN) {
+ if (!identical(endian, Endianness.HOST_ENDIAN)) {
set_value = _toEndianInt64(set_value, endian._littleEndian);
}
_typeddata._setInt64(_offset + byteOffset, set_value);
@@ -2997,7 +2997,7 @@
_throwRangeError(byteOffset, length);
}
var result = _typeddata._getUint64(_offset + byteOffset);
- if (endian === Endianness.HOST_ENDIAN) {
+ if (identical(endian, Endianness.HOST_ENDIAN)) {
return result;
}
return _toEndianUint64(result, endian._littleEndian);
@@ -3009,7 +3009,7 @@
_throwRangeError(byteOffset, length);
}
var set_value = _toUint64(value);
- if (endian !== Endianness.HOST_ENDIAN) {
+ if (!identical(endian, Endianness.HOST_ENDIAN)) {
set_value = _toEndianUint64(set_value, endian._littleEndian);
}
_typeddata._setUint64(_offset + byteOffset, set_value);
@@ -3021,7 +3021,7 @@
_throwRangeError(byteOffset, length);
}
var result = _typeddata._getFloat32(_offset + byteOffset);
- if (endian === Endianness.HOST_ENDIAN) {
+ if (identical(endian, Endianness.HOST_ENDIAN)) {
return result;
}
return _toEndianFloat32(result, endian._littleEndian);
@@ -3033,7 +3033,7 @@
_throwRangeError(byteOffset, length);
}
var set_value = value;
- if (endian !== Endianness.HOST_ENDIAN) {
+ if (!identical(endian, Endianness.HOST_ENDIAN)) {
set_value = _toEndianFloat32(set_value, endian._littleEndian);
}
_typeddata._setFloat32(_offset + byteOffset, set_value);
@@ -3045,7 +3045,7 @@
_throwRangeError(byteOffset, length);
}
var result = _typeddata._getFloat64(_offset + byteOffset);
- if (endian === Endianness.HOST_ENDIAN) {
+ if (identical(endian, Endianness.HOST_ENDIAN)) {
return result;
}
return _toEndianFloat64(result, endian._littleEndian);
@@ -3057,7 +3057,7 @@
_throwRangeError(byteOffset, length);
}
var set_value = value;
- if (endian !== Endianness.HOST_ENDIAN) {
+ if (!identical(endian, Endianness.HOST_ENDIAN)) {
set_value = _toEndianFloat64(set_value, endian._littleEndian);
}
_typeddata._setFloat64(_offset + byteOffset, set_value);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698