Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 14352011: Fix missing Smi check in grow mode keyed stores. (Closed)

Created:
7 years, 8 months ago by Michael Starzinger
Modified:
7 years, 8 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Fix missing Smi check in grow mode keyed stores. R=danno@chromium.org TEST=mjsunit/regress/regress-grow-store-smi-check Committed: http://code.google.com/p/v8/source/detail?r=14332

Patch Set 1 #

Patch Set 2 : Use local zone variable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -14 lines) Patch
M src/hydrogen.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-grow-store-smi-check.js View 1 chunk +20 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 8 months ago (2013-04-18 14:08:58 UTC) #1
danno
lgtm
7 years, 8 months ago (2013-04-18 14:12:45 UTC) #2
Michael Starzinger
7 years, 8 months ago (2013-04-18 14:18:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r14332 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698