Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 14352009: Double the timeout values when running under ThreadSanitizer v2. It is at least as slow as AddressS… (Closed)

Created:
7 years, 8 months ago by Alexander Potapenko
Modified:
7 years, 8 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Double the timeout values when running under ThreadSanitizer v2. It is at least as slow as AddressSanitizer, if not worse. BUG=128314 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195144

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M base/test/test_timeouts.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Alexander Potapenko
PTAL
7 years, 8 months ago (2013-04-18 13:50:37 UTC) #1
Paweł Hajdan Jr.
LGTM Nice to have these timeouts in one place, isn't it? :)
7 years, 8 months ago (2013-04-18 17:41:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/14352009/1
7 years, 8 months ago (2013-04-18 17:45:25 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-18 17:55:39 UTC) #4
Alexander Potapenko
7 years, 8 months ago (2013-04-19 12:56:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r195144 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698