Split Media-related code from IsolatedMountPointProvider

webkit/fileapi/media/native_media_file_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/fileapi/media/native_media_file_util.h"
 
 #include "webkit/fileapi/file_system_operation_context.h"
-#include "webkit/fileapi/isolated_mount_point_provider.h"
 #include "webkit/fileapi/media/filtering_file_enumerator.h"
+#include "webkit/fileapi/media/media_file_system_mount_point_provider.h"
 #include "webkit/fileapi/media/media_path_filter.h"
 #include "webkit/fileapi/native_file_util.h"
 
 using base::PlatformFile;
 using base::PlatformFileError;
 using base::PlatformFileInfo;
 
 namespace fileapi {
 
 namespace {
 
 MediaPathFilter* GetMediaPathFilter(FileSystemOperationContext* context) {
   return context->GetUserValue<MediaPathFilter*>(
-          IsolatedMountPointProvider::kMediaPathFilterKey);
+          MediaFileSystemMountPointProvider::kMediaPathFilterKey);

[Greg Billock, 2013/04/18 16:18:02]

I don't understand why this fileutil would know about MediaPathFilter. Is this
just part of the way to decoupling? Or is this just something different that
doesn't even belong in MediaFileSystemMountPointProvider?

[kinuko, 2013/04/19 15:19:32]

My assumption here is: MediaFSMountPointProvider and media-related file utils
belong to the same MediaGalleries module (or MediaFS module), so they may share
some common variables like this, while FileAPI layer doesn't know anything about
Media so it just provides general setter like {Set,Get}UserValue like this for
FS modules to get/set their own variables.  Let me know if this assumption
doesn't fit with the model in your mind.

[Greg Billock, 2013/04/19 15:27:47]

No, that makes sense. I was thinking I was in native_file_util.

On 2013/04/19 15:19:32, kinuko wrote:

 }
 
 }  // namespace
 
 NativeMediaFileUtil::NativeMediaFileUtil() {
 }
 
 PlatformFileError NativeMediaFileUtil::CreateOrOpen(
     FileSystemOperationContext* context,
     const FileSystemURL& url,
@@ skipping 183 matching lines @@
   if (!file_info.is_directory &&
       !GetMediaPathFilter(context)->Match(file_path)) {
     return failure_error;
   }
 
   *local_file_path = file_path;
   return base::PLATFORM_FILE_OK;
 }
 
 }  // namespace fileapi