Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

Issue 1435183002: WebGL 2: fix the bug in invalidate-framebuffer.html (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed Ken's feedback Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
index 3ab1aad20babffd691efbe1d197ef173b49c5bed..726ceb2162279fc9c87015c4ae519d98a825dd8b 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
@@ -36,8 +36,8 @@ public:
void blitFramebuffer(GLint, GLint, GLint, GLint, GLint, GLint, GLint, GLint, GLbitfield, GLenum);
void framebufferTextureLayer(ScriptState*, GLenum, GLenum, WebGLTexture*, GLint, GLint);
ScriptValue getInternalformatParameter(ScriptState*, GLenum, GLenum, GLenum);
- void invalidateFramebuffer(GLenum, Vector<GLenum>&);
- void invalidateSubFramebuffer(GLenum, Vector<GLenum>&, GLint, GLint, GLsizei, GLsizei);
+ void invalidateFramebuffer(GLenum, const Vector<GLenum>&);
+ void invalidateSubFramebuffer(GLenum, const Vector<GLenum>&, GLint, GLint, GLsizei, GLsizei);
void readBuffer(GLenum);
/* Renderbuffer objects */
@@ -213,6 +213,8 @@ protected:
void vertexAttribIivImpl(const char*, GLuint, const GLint*, GLsizei);
void vertexAttribIuivImpl(const char*, GLuint, const GLuint*, GLsizei);
+ bool checkAndTranslateAttachments(const char* functionName, GLenum, const Vector<GLenum>&, Vector<GLenum>&);
+
/* WebGLRenderingContextBase overrides */
unsigned getMaxWebGLLocationLength() const override { return 1024; };
bool validateCapability(const char* functionName, GLenum) override;

Powered by Google App Engine
This is Rietveld 408576698