Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1435153007: Use FunctionElementImpl for inline function type parameters (Closed)

Created:
5 years, 1 month ago by Jennifer Messerly
Modified:
5 years, 1 month ago
Reviewers:
Leaf, Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use FunctionElementImpl for inline function type parameters This lets it have the right enclosingElement, and thus typeParameters. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/79de8d80935fd123a95e71404ed3190676f95868

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -51 lines) Patch
M pkg/analyzer/lib/src/generated/element.dart View 2 chunks +9 lines, -18 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +6 lines, -23 lines 2 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 2 chunks +31 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jennifer Messerly
Treating it more like a local function works better for type substitution.
5 years, 1 month ago (2015-11-13 23:19:35 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1435153007/diff/1/pkg/analyzer/lib/src/generated/resolver.dart File pkg/analyzer/lib/src/generated/resolver.dart (right): https://codereview.chromium.org/1435153007/diff/1/pkg/analyzer/lib/src/generated/resolver.dart#newcode14925 pkg/analyzer/lib/src/generated/resolver.dart:14925: // FunctionTypeAliasElementImpl assumes the enclosing element is a ...
5 years, 1 month ago (2015-11-14 17:05:09 UTC) #3
Jennifer Messerly
Committed patchset #1 (id:1) manually as 79de8d80935fd123a95e71404ed3190676f95868 (presubmit successful).
5 years, 1 month ago (2015-11-16 21:50:47 UTC) #4
Jennifer Messerly
5 years, 1 month ago (2015-11-16 21:51:07 UTC) #5
Message was sent while issue was closed. 
Thanks!

https://codereview.chromium.org/1435153007/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1435153007/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:14925: //
FunctionTypeAliasElementImpl assumes the enclosing element is a
On 2015/11/14 17:05:09, Brian Wilkerson wrote:
> This comment is obsolete and should be removed.

Done.

Powered by Google App Engine
This is Rietveld 408576698