Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1435153005: Fix summary_test.dart on Windows. (Closed)

Created:
5 years, 1 month ago by Paul Berry
Modified:
5 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix summary_test.dart on Windows. On Windows, absolute file URIs include a drive letter (e.g. "file:///C:/foo.dart"). Added a helper function "absUri" which generates the correct kind of absolute file URI for the platform. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/101883988b6300b303b8afc2631682cd00beddd1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -26 lines) Patch
M pkg/analyzer/test/src/summary/summary_test.dart View 13 chunks +36 lines, -26 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 1 month ago (2015-11-13 18:22:42 UTC) #2
scheglov
LGTM
5 years, 1 month ago (2015-11-13 18:43:33 UTC) #3
Paul Berry
5 years, 1 month ago (2015-11-13 18:54:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
101883988b6300b303b8afc2631682cd00beddd1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698