third_party/WebKit/Source/web/tests/VisualViewportTest.cpp - Issue 1435113003: Make use of new AX name calc in Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Issue 1435113003: Make use of new AX name calc in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix issue with ariaTextAlternative Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

index 6781d0b1bbe1645abb09b0e5b8eac41ce11ca83c..17e046ac8899753a0a98fcbd80567511fc40306f 100644

--- a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

+++ b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

@@ -1509,7 +1509,9 @@ TEST_P(ParameterizedVisualViewportTest, AccessibilityHitTestWhileZoomedIn)

// Because of where the visual viewport is located, this should hit the bottom right

// target (target 4).

WebAXObject hitNode = webDoc.accessibilityObject().hitTest(WebPoint(154, 165));

- EXPECT_EQ(std::string("Target4"), hitNode.title().utf8());

+ WebAXNameFrom nameFrom;

+ WebVector<WebAXObject> nameObjects;

+ EXPECT_EQ(std::string("Target4"), hitNode.name(nameFrom, nameObjects).utf8());

}

// Tests that the maximum scroll offset of the viewport can be fractional.