third_party/WebKit/Source/modules/accessibility/AXMediaControls.h - Issue 1435113003: Make use of new AX name calc in Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXMediaControls.h

Issue 1435113003: Make use of new AX name calc in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix issue with ariaTextAlternative Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXMediaControls.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXMediaControls.h

diff --git a/third_party/WebKit/Source/modules/accessibility/AXMediaControls.h b/third_party/WebKit/Source/modules/accessibility/AXMediaControls.h

index 6520e616b651d8b1938bd78620ff182d7691b891..589d4a90c88ffb4d56b8739dfda53b379da9be72 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXMediaControls.h

+++ b/third_party/WebKit/Source/modules/accessibility/AXMediaControls.h

@@ -45,9 +45,8 @@ public:

AccessibilityRole roleValue() const override;

- String deprecatedTitle(TextUnderElementMode) const final;

- String deprecatedAccessibilityDescription() const override;

- String deprecatedHelpText() const override;

+ String textAlternative(bool recursive, bool inAriaLabelledByTraversal, AXObjectSet& visited, AXNameFrom&, AXRelatedObjectVector*, NameSources*) const override;

+ String description(AXNameFrom, AXDescriptionFrom&, AXObjectVector* descriptionObjects) const override;

protected:

AccessibilityMediaControl(LayoutObject*, AXObjectCacheImpl&);

@@ -62,7 +61,7 @@ public:

static AXObject* create(LayoutObject*, AXObjectCacheImpl&);

~AccessibilityMediaTimeline() override { }

- String deprecatedHelpText() const override;

+ String description(AXNameFrom, AXDescriptionFrom&, AXObjectVector* descriptionObjects) const override;

String valueDescription() const override;

const AtomicString& getAttribute(const QualifiedName& attribute) const;

@@ -79,8 +78,8 @@ public:

AccessibilityRole roleValue() const override { return ToolbarRole; }

- String deprecatedHelpText() const override;

- String deprecatedAccessibilityDescription() const override;

+ String textAlternative(bool recursive, bool inAriaLabelledByTraversal, AXObjectSet& visited, AXNameFrom&, AXRelatedObjectVector*, NameSources*) const override;

+ String description(AXNameFrom, AXDescriptionFrom&, AXObjectVector* descriptionObjects) const override;

private:

AXMediaControlsContainer(LayoutObject*, AXObjectCacheImpl&);

@@ -98,7 +97,7 @@ public:

AccessibilityRole roleValue() const override { return StaticTextRole; }

String stringValue() const override;

- String deprecatedAccessibilityDescription() const override;

+ String textAlternative(bool recursive, bool inAriaLabelledByTraversal, AXObjectSet& visited, AXNameFrom&, AXRelatedObjectVector*, NameSources*) const override;

private:

AccessibilityMediaTimeDisplay(LayoutObject*, AXObjectCacheImpl&);