third_party/WebKit/Source/modules/accessibility/AXListBoxOption.h - Issue 1435113003: Make use of new AX name calc in Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXListBoxOption.h

Issue 1435113003: Make use of new AX name calc in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update inspector-protocol test expectations Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp » ('j') | third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXListBoxOption.h

diff --git a/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.h b/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.h

index 680455fa80397bbbbb64a91ab37b08a09fcffb5e..c8e5e8ac6c9c826a4bddf664d73c82f02c6ffeeb 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.h

+++ b/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.h

@@ -54,8 +54,7 @@ public:

bool isSelectedOptionActive() const override;

void setSelected(bool) override;

bool canSetSelectedAttribute() const override;

- String stringValue() const override;

- String deprecatedTitle(TextUnderElementMode) const override { return String(); }

+ String textAlternative(bool recursive, bool inAriaLabelledByTraversal, AXObjectSet& visited, AXNameFrom&, AXRelatedObjectVector*, NameSources*) const override;

private:

bool canHaveChildren() const override { return false; }