content/test/data/accessibility/html/input-datetime-local-expected-win.txt - Issue 1435113003: Make use of new AX name calc in Chromium.

Side by Side Diff: content/test/data/accessibility/html/input-datetime-local-expected-win.txt

Issue 1435113003: Make use of new AX name calc in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix ChromeVox and Automation API tests Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/renderer/accessibility/blink_ax_tree_source.cc ('K') | « content/test/data/accessibility/html/input-datetime-local.html ('k') | content/test/data/accessibility/html/input-text-name-calc-expected-android.txt » ('j') | third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE ia2_hypertext='<obj0>'	1 ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE ia2_hypertext='<obj0>'

2 ++IA2_ROLE_SECTION ia2_hypertext='<obj0>'	2 ++IA2_ROLE_SECTION ia2_hypertext='<obj0>'

3 ++++IA2_ROLE_DATE_EDITOR FOCUSABLE ia2_hypertext='<obj0><obj1><obj2>'	3 ++++IA2_ROLE_DATE_EDITOR FOCUSABLE ia2_hypertext='<obj0><obj1><obj2>'

4 ++++++IA2_ROLE_SECTION ia2_hypertext='<obj0>'	4 ++++++IA2_ROLE_SECTION ia2_hypertext='<obj0>'

5 ++++++++IA2_ROLE_SECTION ia2_hypertext='<obj0>/<obj2>/<obj4><obj5>:<obj7><obj8>'	5 ++++++++IA2_ROLE_SECTION ia2_hypertext='<obj0>/<obj2>/<obj4><obj5>:<obj7><obj8>'

6 ++++++++++ROLE_SYSTEM_SPINBUTTON name='Month' FOCUSABLE ia2_hypertext='Month'	6 ++++++++++ROLE_SYSTEM_SPINBUTTON FOCUSABLE description='Month'
aboxhall 2015/11/13 23:13:49 This change is expected? This change is expected? dmazzoni 2015/11/16 18:52:04 Yes. The previous logic promoted this to the acces Show quoted text On 2015/11/13 23:13:49, aboxhall wrote: > This change is expected? Yes. The previous logic promoted this to the accessible name but the new logic leaves it as the description, because we want the author to be able to label the overall control. For example: <label> Event start date <input type="datetime"> </label> We don't want the "Month" label on the first inner text field to override the "event start date" text, so we let "event start date" be the name, and "month" the description. Perhaps aria-placeholder would be a better fit for this once we support it. I think it's in the draft spec now.
7 ++++++++++ROLE_SYSTEM_STATICTEXT name='/' ia2_hypertext='/'	7 ++++++++++ROLE_SYSTEM_STATICTEXT name='/' ia2_hypertext='/'

8 ++++++++++ROLE_SYSTEM_SPINBUTTON name='Day' FOCUSABLE ia2_hypertext='Day'	8 ++++++++++ROLE_SYSTEM_SPINBUTTON FOCUSABLE description='Day'

9 ++++++++++ROLE_SYSTEM_STATICTEXT name='/' ia2_hypertext='/'	9 ++++++++++ROLE_SYSTEM_STATICTEXT name='/' ia2_hypertext='/'

10 ++++++++++ROLE_SYSTEM_SPINBUTTON name='Year' FOCUSABLE ia2_hypertext='Year'	10 ++++++++++ROLE_SYSTEM_SPINBUTTON FOCUSABLE description='Year'

11 ++++++++++ROLE_SYSTEM_SPINBUTTON name='Hours' FOCUSABLE ia2_hypertext='Hours'	11 ++++++++++ROLE_SYSTEM_SPINBUTTON FOCUSABLE description='Hours'

12 ++++++++++ROLE_SYSTEM_STATICTEXT name=':' ia2_hypertext=':'	12 ++++++++++ROLE_SYSTEM_STATICTEXT name=':' ia2_hypertext=':'

13 ++++++++++ROLE_SYSTEM_SPINBUTTON name='Minutes' FOCUSABLE ia2_hypertext='Minutes '	13 ++++++++++ROLE_SYSTEM_SPINBUTTON FOCUSABLE description='Minutes'

14 ++++++++++ROLE_SYSTEM_SPINBUTTON name='AM/PM' FOCUSABLE ia2_hypertext='AM/PM'	14 ++++++++++ROLE_SYSTEM_SPINBUTTON FOCUSABLE description='AM/PM'

15 ++++++ROLE_SYSTEM_BUTTONMENU FOCUSABLE	15 ++++++ROLE_SYSTEM_BUTTONMENU FOCUSABLE

16 ++++++ROLE_SYSTEM_SPINBUTTON ia2_hypertext='<obj0><obj1>'	16 ++++++ROLE_SYSTEM_SPINBUTTON ia2_hypertext='<obj0><obj1>'

17 ++++++++ROLE_SYSTEM_PUSHBUTTON	17 ++++++++ROLE_SYSTEM_PUSHBUTTON

18 ++++++++ROLE_SYSTEM_PUSHBUTTON	18 ++++++++ROLE_SYSTEM_PUSHBUTTON

OLD	NEW