Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1435083003: [JSON stringifier] Correctly load array elements. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[JSON stringifier] Correctly load array elements. BUG=chromium:554946 LOG=y R=jkummerow@chromium.org, jochen@chromium.org Committed: https://crrev.com/6df9a1db8c85ab63dee63879456b6027df53fabc Cr-Commit-Position: refs/heads/master@{#31968}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -48 lines) Patch
M src/json-stringifier.h View 1 chunk +2 lines, -48 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-554946.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Yang
5 years, 1 month ago (2015-11-12 18:45:54 UTC) #1
Yang
On 2015/11/12 18:45:54, Yang wrote: This will tank performance, but let's implement it this way ...
5 years, 1 month ago (2015-11-12 18:46:39 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 1 month ago (2015-11-12 18:49:48 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435083003/1
5 years, 1 month ago (2015-11-12 18:49:55 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-12 19:07:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1435083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1435083003/1
5 years, 1 month ago (2015-11-12 19:28:56 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 19:30:13 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:21:00 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6df9a1db8c85ab63dee63879456b6027df53fabc
Cr-Commit-Position: refs/heads/master@{#31968}

Powered by Google App Engine
This is Rietveld 408576698