Issue 1435043002: EDK: Sprinkle some more |final| secret sauce.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1435043002: EDK: Sprinkle some more |final| secret sauce. (Closed)

Created:
5 years, 1 month ago by viettrungluu

Modified:
5 years, 1 month ago

Reviewers:
jamesr

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

EDK: Sprinkle some more |final| secret sauce. Don't go around subclassing RefPtr. Or Mutex. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/49824cbc93df9b7e007db65a7f45ceb26964d166

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -17 lines)			Patch
M	mojo/edk/system/test/scoped_test_dir.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/system/test/stopwatch.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/system/test/test_io_thread.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/test/multiprocess_test_helper.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/test/scoped_ipc_support.h	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	mojo/edk/util/command_line.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/edk/util/cond_var.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/util/mutex.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/edk/util/ref_ptr.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/util/ref_ptr_internal.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/util/waitable_event.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

5 years, 1 month ago (2015-11-11 20:47:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
49824cbc93df9b7e007db65a7f45ceb26964d166 (presubmit successful).

Expand Messages | Collapse Messages