Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Issue 143503003: Chromium Codereview Comparison Script. (Closed)

Created:
6 years, 11 months ago by hal.canary
Modified:
6 years, 11 months ago
Reviewers:
borenet, robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Chromium Codereview Comparison Script. This script takes two Codereview URLs, looks at the trybot results for the two codereviews and compares the results. Motivation: This should speed up the DEPS roll procedure. BUG=skia:2039 Committed: http://code.google.com/p/skia/source/detail?r=13144

Patch Set 1 #

Total comments: 8

Patch Set 2 : ELI5 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+387 lines, -0 lines) Patch
A tools/compare_codereview.py View 1 1 chunk +387 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hal.canary
ptal [DONE] Still need to suppress configs where roll is green [DONE] Need to burrow ...
6 years, 11 months ago (2014-01-21 19:37:41 UTC) #1
robertphillips
lgtm but really need to add a python person (maybe Eric?)
6 years, 11 months ago (2014-01-21 20:23:02 UTC) #2
hal.canary
Eric, can you comment on the Pythoness of this? For background, we expect Robert to ...
6 years, 11 months ago (2014-01-21 21:31:43 UTC) #3
borenet
Looks fine with some nits. I don't particularly like HTMLParser; its flow makes for hard-to-read ...
6 years, 11 months ago (2014-01-21 21:55:42 UTC) #4
hal.canary
ptal https://codereview.chromium.org/143503003/diff/1/tools/compare_codereview.py File tools/compare_codereview.py (right): https://codereview.chromium.org/143503003/diff/1/tools/compare_codereview.py#newcode32 tools/compare_codereview.py:32: """ On 2014/01/21 21:55:43, borenet wrote: > I'd ...
6 years, 11 months ago (2014-01-22 15:25:32 UTC) #5
borenet
Thanks for the changes. LGTM.
6 years, 11 months ago (2014-01-22 21:31:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/143503003/90001
6 years, 11 months ago (2014-01-22 22:45:11 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-22 22:57:22 UTC) #8
Message was sent while issue was closed.
Change committed as 13144

Powered by Google App Engine
This is Rietveld 408576698