Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1434933002: dart2js CPS: Triage an issue in the corelib tests. (Closed)

Created:
5 years, 1 month ago by Kevin Millikin (Google)
Modified:
5 years, 1 month ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js CPS: Triage an issue in the corelib tests. R=asgerf@google.com BUG=https://github.com/dart-lang/sdk/issues/24878 Committed: https://github.com/dart-lang/sdk/commit/d20d3f64198471b43d97bc42e19bdf9dfc11562b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/corelib/corelib.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Kevin Millikin (Google)
5 years, 1 month ago (2015-11-11 10:30:29 UTC) #1
asgerf
lgtm
5 years, 1 month ago (2015-11-11 10:31:25 UTC) #3
Kevin Millikin (Google)
5 years, 1 month ago (2015-11-11 10:32:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d20d3f64198471b43d97bc42e19bdf9dfc11562b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698