chrome/common/extensions/api/manifest_types.json - Issue 143493005: Allow extensions to remove and override the bookmark shortcut key

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/manifest_types.json

Issue 143493005: Allow extensions to remove and override the bookmark shortcut key (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove use of GetActiveDesktop() Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_keybinding_apitest.cc ('K') | « chrome/browser/ui/views/accelerator_utils_aura.cc ('k') | chrome/common/extensions/docs/templates/articles/settings_override.html » ('j') | chrome/common/extensions/docs/templates/articles/settings_override.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/manifest_types.json

diff --git a/chrome/common/extensions/api/manifest_types.json b/chrome/common/extensions/api/manifest_types.json

index 7f8f3af6f704014acf24ceacc02063a915a32f80..de18f164b0cd621e2905c6785058b8715fb75d77 100644

--- a/chrome/common/extensions/api/manifest_types.json

+++ b/chrome/common/extensions/api/manifest_types.json

@@ -53,6 +53,11 @@

"description": "If <code>true</code>, the built-in bookmark button will be removed from the user interface.",

"optional": true

+ "remove_bookmark_shortcut": {

+ "type": "boolean",

+ "description": "If <code>true</code>, the built-in \"Bookmark this page...\" shortcut key is removed and the extension is permitted to override the shortcut by binding it in the commands section of the manifest.",

+ "optional": true

+ },

Finnur 2014/02/10 10:14:18 Usually, we restrict new APIs to the dev channel u

Mike Wittman 2014/02/11 23:09:45 No, it's restricted to dev via _manifest_features.

// TODO(wittman): Remove for M36.

"hide_bookmark_button": {

"type": "boolean",