Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: chrome/browser/ui/omnibox/location_bar.cc

Issue 143493005: Allow extensions to remove and override the bookmark shortcut key (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add docs and tests Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/omnibox/location_bar.cc
diff --git a/chrome/browser/ui/omnibox/location_bar.cc b/chrome/browser/ui/omnibox/location_bar.cc
index c0ac254bce0cc900bf99c9f891e3eacfa83120bb..5f6b358fd2b6fae5da111d4fea569ec08f673dbb 100644
--- a/chrome/browser/ui/omnibox/location_bar.cc
+++ b/chrome/browser/ui/omnibox/location_bar.cc
@@ -30,9 +30,11 @@ bool LocationBar::IsBookmarkStarHiddenByExtension() const {
extension_service->extensions();
for (extensions::ExtensionSet::const_iterator i = extension_set->begin();
i != extension_set->end(); ++i) {
- const extensions::SettingsOverrides* settings_overrides =
- extensions::SettingsOverrides::Get(i->get());
- if (settings_overrides && settings_overrides->RemovesBookmarkButton() &&
+ using extensions::SettingsOverrides;
+ const SettingsOverrides* settings_overrides =
+ SettingsOverrides::Get(i->get());
+ if (settings_overrides &&
+ SettingsOverrides::RemovesBookmarkButton(*settings_overrides) &&
(extensions::PermissionsData::HasAPIPermission(
*i,
extensions::APIPermission::kBookmarkManagerPrivate) ||

Powered by Google App Engine
This is Rietveld 408576698