chrome/common/extensions/manifest_handlers/settings_overrides_handler.h - Issue 143493005: Allow extensions to remove and override the bookmark shortcut key

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/settings_overrides_handler.h

Issue 143493005: Allow extensions to remove and override the bookmark shortcut key (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: update mac test fix Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/templates/public/extensions/settings_override.html ('k') | chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/settings_overrides_handler.h

diff --git a/chrome/common/extensions/manifest_handlers/settings_overrides_handler.h b/chrome/common/extensions/manifest_handlers/settings_overrides_handler.h

index e63fe8667c11ead7363024e4e6d8ed6a3aa3b918..8f7490a746007c990c01a6af90db390af59a8018 100644

--- a/chrome/common/extensions/manifest_handlers/settings_overrides_handler.h

+++ b/chrome/common/extensions/manifest_handlers/settings_overrides_handler.h

@@ -22,7 +22,10 @@ struct SettingsOverrides : public Extension::ManifestData {

static const SettingsOverrides* Get(const Extension* extension);

- bool RemovesBookmarkButton() const;

+ static bool RemovesBookmarkButton(

+ const SettingsOverrides& settings_overrides);

+ static bool RemovesBookmarkShortcut(

+ const SettingsOverrides& settings_overrides);

scoped_ptr<api::manifest_types::ChromeSettingsOverrides::Bookmarks_ui>

bookmarks_ui;