chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc - Issue 143493005: Allow extensions to remove and override the bookmark shortcut key

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc

Issue 143493005: Allow extensions to remove and override the bookmark shortcut key (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/manifest_handlers/settings_overrides_handler.h ('K') | « chrome/common/extensions/manifest_handlers/settings_overrides_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc

diff --git a/chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc b/chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc

index 0233edbd18e6a9338906faa0e8ac0670dd17f88d..a2cb9ec97355bf4be2c9485119b167414d55981f 100644

--- a/chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc

+++ b/chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc

@@ -225,6 +225,11 @@ bool SettingsOverrides::RemovesBookmarkButton() const {

*bookmarks_ui->remove_button;

}

+bool SettingsOverrides::RemovesBookmarkShortcut() const {

+ return bookmarks_ui && bookmarks_ui->remove_bookmark_shortcut &&

+ *bookmarks_ui->remove_bookmark_shortcut;

SettingsOverridesHandler::SettingsOverridesHandler() {}

SettingsOverridesHandler::~SettingsOverridesHandler() {}