Allow extensions to remove and override the bookmark shortcut key

chrome/common/extensions/manifest_handlers/settings_overrides_handler.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_SETTINGS_OVERRIDES_HANDLER_H_
 #define CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_SETTINGS_OVERRIDES_HANDLER_H_
 
 #include "chrome/common/extensions/api/manifest_types.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/manifest_handler.h"
 
 namespace extensions {
 
 class ManifestPermission;
 
 // SettingsOverride is associated with "chrome_settings_overrides" manifest key.
 // An extension can add a search engine as default or non-default, overwrite the
 // homepage and append a startup page to the list.
 struct SettingsOverrides : public Extension::ManifestData {

[Finnur, 2014/02/05 13:37:40]

This isn't purely about data anymore - Why is this still a struct?

[Mike Wittman, 2014/02/05 19:17:07]

Mainly for consistency with the other subclasses of Extension::ManifestData.
I've changed the members to static functions to live within the style
guidelines.

   SettingsOverrides();
   virtual ~SettingsOverrides();
 
   static const SettingsOverrides* Get(const Extension* extension);
 
   bool RemovesBookmarkButton() const;
+  bool RemovesBookmarkShortcut() const;
 
   scoped_ptr<api::manifest_types::ChromeSettingsOverrides::Bookmarks_ui>
       bookmarks_ui;
   scoped_ptr<api::manifest_types::ChromeSettingsOverrides::Search_provider>
       search_engine;
   scoped_ptr<GURL> homepage;
   std::vector<GURL> startup_pages;
 
   scoped_ptr<ManifestPermission> manifest_permission;
 
@@ skipping 18 matching lines @@
  private:
   class ManifestPermissionImpl;
 
   virtual const std::vector<std::string> Keys() const OVERRIDE;
 
   DISALLOW_COPY_AND_ASSIGN(SettingsOverridesHandler);
 };
 
 }  // namespace extensions
 #endif  // CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_SETTINGS_OVERRIDES_HANDLER_H_