chrome/browser/ui/accelerator_utils.h - Issue 143493005: Allow extensions to remove and override the bookmark shortcut key

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/accelerator_utils.h

Issue 143493005: Allow extensions to remove and override the bookmark shortcut key (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/extensions/api/commands/command_service.cc ('K') | « chrome/browser/extensions/api/commands/command_service.cc ('k') | chrome/browser/ui/cocoa/accelerator_utils_cocoa.mm » ('j') | chrome/browser/ui/views/accelerator_utils_views.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_ACCELERATOR_UTILS_H_	5 #ifndef CHROME_BROWSER_UI_ACCELERATOR_UTILS_H_

6 #define CHROME_BROWSER_UI_ACCELERATOR_UTILS_H_	6 #define CHROME_BROWSER_UI_ACCELERATOR_UTILS_H_

7	7

8 class Profile;	8 class Profile;

9	9

10 namespace ui {	10 namespace ui {

11 class Accelerator;	11 class Accelerator;

12 }	12 }

13	13

14 namespace chrome {	14 namespace chrome {

15	15

16 // Returns true if the given \|accelerator\| is currently registered by	16 // Returns true if the given \|accelerator\| is currently registered by

17 // Chrome.	17 // Chrome.

18 bool IsChromeAccelerator(const ui::Accelerator& accelerator,	18 bool IsChromeAccelerator(const ui::Accelerator& accelerator,

19 Profile* profile);	19 Profile* profile);

20	20

	21 ui::Accelerator GetChromeAcceleratorForCommandId(int command_id);
	Finnur 2014/02/05 13:37:40 Your design doc talks about not showing the Bookma Your design doc talks about not showing the Bookmark feature in the menu if an extension is overwriting it. This CL does not do that, though. Is that intentional? Mike Wittman 2014/02/05 19:17:07 Yes. I will address the menu aspects in a separate Show quoted text On 2014/02/05 13:37:40, Finnur wrote: > Your design doc talks about not showing the Bookmark feature in the menu if an > extension is overwriting it. This CL does not do that, though. Is that > intentional? Yes. I will address the menu aspects in a separate CL.
	22

21 } // namespace chrome	23 } // namespace chrome

22	24

23 #endif // CHROME_BROWSER_UI_ACCELERATOR_UTILS_H_	25 #endif // CHROME_BROWSER_UI_ACCELERATOR_UTILS_H_

OLD	NEW