Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 143493004: Add missing gfx_unittests entries to all.gyp. (Closed)

Created:
6 years, 10 months ago by tfarina
Modified:
6 years, 10 months ago
Reviewers:
Avi (use Gerrit), Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Add missing gfx_unittests entries to all.gyp. That should fix the Mac 64 tester redness in (http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Mac%2010.8%20x64%20tester%20(experimental) ) because it wasn't finding the gfx_unittests binary. BUG=331829 TEST=None R=avi@chromium.org,thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248116

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M build/all.gyp View 8 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
6 years, 10 months ago (2014-01-31 00:14:47 UTC) #1
Nico
Shouldn't this be in chromium_builder_tests instead?
6 years, 10 months ago (2014-01-31 00:17:28 UTC) #2
tfarina
On 2014/01/31 00:17:28, Nico wrote: > Shouldn't this be in chromium_builder_tests instead? That is line ...
6 years, 10 months ago (2014-01-31 00:21:37 UTC) #3
Nico
lgtm I guess, but this file is a mess :-(
6 years, 10 months ago (2014-01-31 00:23:29 UTC) #4
tfarina
On 2014/01/31 00:23:29, Nico wrote: > lgtm I guess, but this file is a mess ...
6 years, 10 months ago (2014-01-31 00:25:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/143493004/1
6 years, 10 months ago (2014-01-31 00:26:28 UTC) #6
commit-bot: I haz the power
Change committed as 248116
6 years, 10 months ago (2014-01-31 03:23:24 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-01-31 03:23:30 UTC) #8
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698