Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1434903002: InternalResourcePtr: allowed only as stack allocated. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

InternalResourcePtr: allowed only as stack allocated. R=haraken BUG=503485 Committed: https://crrev.com/7a125b9442268e912388e692b26b729070ee8fe3 Cr-Commit-Position: refs/heads/master@{#359079}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/core/fetch/Resource.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
sof
please take a look.
5 years, 1 month ago (2015-11-11 09:36:10 UTC) #2
haraken
LGTM
5 years, 1 month ago (2015-11-11 09:41:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434903002/1
5 years, 1 month ago (2015-11-11 09:46:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 10:58:33 UTC) #7
commit-bot: I haz the power
Failed to apply the patch.
5 years, 1 month ago (2015-11-11 10:58:51 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 10:59:45 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a125b9442268e912388e692b26b729070ee8fe3
Cr-Commit-Position: refs/heads/master@{#359079}

Powered by Google App Engine
This is Rietveld 408576698