Build NaCl browser tests with GN

build/config/nacl/BUILD.gn

 # Copyright (c) 2014 The Native Client Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/nacl/config.gni")
 
 # Native Client Definitions
 config("nacl_defines") {
   if (is_linux || is_android || is_nacl) {
     defines = [
       "_POSIX_C_SOURCE=199506",
       "_XOPEN_SOURCE=600",
       "_GNU_SOURCE=1",
       "__STDC_LIMIT_MACROS=1",
     ]
   } else if (is_win) {
     defines = [ "__STDC_LIMIT_MACROS=1" ]
   }
+
+  if (current_cpu == "pnacl" && !is_nacl_nonsfi) {
+    defines += [ "NACL_BUILD_ARCH=pnacl" ]

[Roland McGrath, 2015/11/11 06:22:44]

What needs this?  I thought we'd changed the code not to require the
NACL_BUILD_* predefines any more.

[Petr Hosek, 2015/11/13 22:18:32]

PNaCl tests which depend on //native_client/src/shared/platform (which seems to
be needed for NaClLog). This dependency includes
trusted/service_runtime/nacl_config.h, which causes build error because
NACL_BUILD_ARCH is undefined. There's a TODO in include/build_config.h from
teravest@ related to this which doesn't seem to be fixed yet.

+  }
 }
 
 config("nexe_defines") {
   defines = [
     "DYNAMIC_ANNOTATIONS_ENABLED=1",
     "DYNAMIC_ANNOTATIONS_PREFIX=NACL_",
   ]
 }
 
 config("nacl_warnings") {
@@ skipping 99 matching lines @@
     "-Os",
 
     # These are omitted from non-IRT libraries to keep the libraries
     # themselves small.
     "-ffunction-sections",
     "-fdata-sections",
   ]
 
   ldflags = [ "-Wl,--gc-sections" ]
 }