Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1434813002: Add support for EGLImage to GrGLInterface (Closed)

Created:
5 years, 1 month ago by bsalomon
Modified:
5 years, 1 month ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add support for EGLImage to GrGLInterface BUG=skia: Committed: https://skia.googlesource.com/skia/+/b1a32ad51767d7639abc6ba16aae656145d7fc77

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -27 lines) Patch
M include/gpu/gl/GrGLExtensions.h View 2 chunks +5 lines, -2 lines 0 comments Download
M include/gpu/gl/GrGLFunctions.h View 1 chunk +5 lines, -0 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 2 chunks +4 lines, -2 lines 0 comments Download
M include/gpu/gl/GrGLTypes.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 6 chunks +37 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLDefines.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLExtensions.cpp View 3 chunks +32 lines, -18 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/gpu/gl/SkNullGLContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 1451683002 Patch 1
Issue 1451683002 Patch 20001

Messages

Total messages: 13 (4 generated)
bsalomon
I want to use these EGL methods to write tests around GL_TEXTURE_EXTERNAL_OES.
5 years, 1 month ago (2015-11-10 21:18:38 UTC) #2
bsalomon
ping
5 years, 1 month ago (2015-11-12 17:15:30 UTC) #3
egdaniel
woops forgot to hit publish, lgtm
5 years, 1 month ago (2015-11-12 17:29:05 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434813002/20001
5 years, 1 month ago (2015-11-12 17:32:21 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-12 17:44:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434813002/20001
5 years, 1 month ago (2015-11-16 14:37:27 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/b1a32ad51767d7639abc6ba16aae656145d7fc77
5 years, 1 month ago (2015-11-16 14:48:47 UTC) #11
mtklein_C
On 2015/11/16 at 14:48:47, commit-bot wrote: > Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/b1a32ad51767d7639abc6ba16aae656145d7fc77 FYI, breaks ...
5 years, 1 month ago (2015-11-16 16:10:42 UTC) #12
bsalomon
5 years, 1 month ago (2015-11-16 16:12:27 UTC) #13
Message was sent while issue was closed. 
On 2015/11/16 16:10:42, mtklein_C wrote:
> On 2015/11/16 at 14:48:47, commit-bot wrote:
> > Committed patchset #2 (id:20001) as
> https://skia.googlesource.com/skia/+/b1a32ad51767d7639abc6ba16aae656145d7fc77
> 
> FYI, breaks Mac canary bot:
> http://build.chromium.org/p/client.skia/builders/Mac%20Builder/builds/5285

Thanks, working on a fix

Powered by Google App Engine
This is Rietveld 408576698