Move ie7_password namespace to //components, so it can be used by components.

Move ie7_password namespace to //components, so it can be used by components.

This will soon be used by the log-in related bits of WebData, which
will be extracted along with the sign-in logic to //components/signin.

TBR=ben@chromium.org
BUG=233552
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196154

[Jói, 2013-04-19 17:18:52]

Hi,

Please review. I considered the following options in terms of where to move this
code:

a) Where it is now, //components/webdata/encryptor. Kind of belongs there since
it's encryption/decryption-related utility code like the rest of that directory.

b) I also considered renaming //components/webdata/encryptor to e.g.
//components/webdata/passwordutils and moving this code there.

c) I also considered making this code a separate lib, e.g.
//components/ie7_password.

I think (a) or (b) are viable alternatives. Any thoughts on what seems better? 
I'm seeking your opinion first as a chrome/browser/password_manager owner, will
loop other approvals needed in after the fact.

Cheers,
Jói

[Ilya Sherman, 2013-04-20 01:37:25]

LGTM.  I think the current location, i.e. under webdata/encryptor/ is fine,
though IMO it would be even better to move the encryptor logic out of webdata if
it's going to be used by other (non-WebDB) code as well.

https://codereview.chromium.org/14348027/diff/1/chrome/browser/importer/ie_im...
File chrome/browser/importer/ie_importer_unittest_win.cc (right):

https://codereview.chromium.org/14348027/diff/1/chrome/browser/importer/ie_im...
chrome/browser/importer/ie_importer_unittest_win.cc:7: // The order of these
includes is important.
Hmm, this comment makes me wonder if it's actually safe to re-arrange the
includes as you have.

[Jói, 2013-04-22 15:47:45]

Thanks Ilya.

I'd like to see which other components we extract that start using this code,
before moving it to a new location.  I agree that if there are several
components using it, that don't otherwise use webdata, then a separate location
would make sense.

Cheers,
Jói

https://codereview.chromium.org/14348027/diff/1/chrome/browser/importer/ie_im...
File chrome/browser/importer/ie_importer_unittest_win.cc (right):

https://codereview.chromium.org/14348027/diff/1/chrome/browser/importer/ie_im...
chrome/browser/importer/ie_importer_unittest_win.cc:7: // The order of these
includes is important.
On 2013/04/20 01:37:25, Ilya Sherman wrote:
> Hmm, this comment makes me wonder if it's actually safe to re-arrange the
> includes as you have.

I'm pretty sure the only important bit is that <windows.h> 
come first. Just to be safe though I've reverted to the previous order.

[Jói, 2013-04-24 09:09:54]

TBR=ben@chromium.org for #include updates all over.

Cheers,
Jói

[commit-bot: I haz the power, 2013-04-24 09:10:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/14348027/8001

[commit-bot: I haz the power, 2013-04-24 09:10:08]

Failed to apply patch for chrome/browser/signin/DEPS:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  The next patch would create the file chrome/browser/signin/DEPS,
  which already exists!  Skipping patch.
  1 out of 1 hunk ignored

Patch:   N   chrome/browser/signin/DEPS
Index: chrome/browser/signin/DEPS
diff --git a/chrome/browser/signin/DEPS b/chrome/browser/signin/DEPS
new file mode 100644
index
0000000000000000000000000000000000000000..a0b0de5e0a157e6a218d9ba92d4d501c1fa2e383
--- /dev/null
+++ b/chrome/browser/signin/DEPS
@@ -0,0 +1,58 @@
+include_rules = [
+  # Sign-in logic is being componentized (moved to //components, where
+  # it won't depend back on //chrome), so we have restrictive DEPS and
+  # are trying to get the list of temporarily-allowed (!-prefixed
+  # rules) below to zero.
+  "-chrome/common",
+  "-chrome/browser",
+  "+chrome/browser/signin",
+
+  # TODO(joi): Get this list to zero.
+  "!chrome/browser/browser_process.h",
+  "!chrome/browser/content_settings/cookie_settings.h",
+  "!chrome/browser/policy/cloud/user_policy_signin_service.h",
+  "!chrome/browser/policy/cloud/user_policy_signin_service_factory.h",
+  "!chrome/browser/profiles/profile.h",
+  "!chrome/browser/profiles/profile_dependency_manager.h",
+  "!chrome/browser/profiles/profile_info_cache.h",
+  "!chrome/browser/profiles/profile_io_data.h",
+  "!chrome/browser/profiles/profile_keyed_service.h",
+  "!chrome/browser/profiles/profile_keyed_service_factory.h",
+  "!chrome/browser/profiles/profile_manager.h",
+  "!chrome/browser/sync/profile_sync_service.h",
+  "!chrome/browser/sync/profile_sync_service_android.h",
+  "!chrome/browser/sync/profile_sync_service_factory.h",
+  "!chrome/browser/sync/profile_sync_service_observer.h",
+  "!chrome/browser/sync/sync_global_error.h",
+  "!chrome/browser/sync/sync_prefs.h",
+  "!chrome/browser/ui/browser_commands.h",
+  "!chrome/browser/ui/chrome_pages.h",
+  "!chrome/browser/ui/global_error/global_error.h",
+  "!chrome/browser/ui/global_error/global_error_service.h",
+  "!chrome/browser/ui/global_error/global_error_service_factory.h",
+  "!chrome/browser/ui/host_desktop.h",
+  "!chrome/browser/ui/webui/signin/login_ui_service.h",
+  "!chrome/browser/ui/webui/signin/login_ui_service_factory.h",
+  "!chrome/browser/ui/webui/signin/profile_signin_confirmation_dialog.h",
+  "!chrome/browser/ui/webui/signin_internals_ui.h",
+  "!chrome/browser/webdata/web_data_service.h",
+  "!chrome/browser/webdata/web_data_service_factory.h",
+  "!chrome/common/chrome_notification_types.h",
+  "!chrome/common/chrome_switches.h",
+  "!chrome/common/chrome_version_info.h",
+  "!chrome/common/extensions/extension_messages.h",
+  "!chrome/common/pref_names.h",
+  "!chrome/common/url_constants.h",
+]
+
+specific_include_rules = {
+  '.*_[a-z]*test\.cc': [
+    # TODO(joi): Get this list to zero.
+    "!chrome/browser/prefs/browser_prefs.h",
+    "!chrome/browser/sync/profile_sync_service_mock.h",
+    "!chrome/browser/ui/browser.h",
+    "!chrome/browser/ui/singleton_tabs.h",
+    "!chrome/browser/ui/tabs/tab_strip_model.h",
+    "!chrome/browser/ui/webui/sync_promo/sync_promo_ui.h",
+  ],
+}

[commit-bot: I haz the power, 2013-04-24 13:13:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/14348027/12001

[commit-bot: I haz the power, 2013-04-24 13:52:13]

Retried try job too often on ios_dbg_simulator for step(s) base_unittests,
compile, content_unittests, crypto_unittests, googleurl_unittests,
media_unittests, net_unittests, sql_unittests, ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-04-24 14:10:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/14348027/8002

[commit-bot: I haz the power, 2013-04-24 14:11:20]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...

[Jói, 2013-04-24 15:31:19]

Committed patchset #5 manually as r196154 (presubmit successful).