Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 14348015: Send onLaunched to apps that don't listen to onRestarted. (Closed)

Created:
7 years, 8 months ago by koz (OOO until 15th September)
Modified:
7 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Send onLaunched to apps that don't listen to onRestarted. BUG=230667, 162057 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195698

Patch Set 1 #

Total comments: 6

Patch Set 2 : respond to comments #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -10 lines) Patch
M chrome/browser/extensions/api/app_runtime/app_runtime_api.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/event_names.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/event_names.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/platform_app_launcher.cc View 1 2 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
koz (OOO until 15th September)
7 years, 8 months ago (2013-04-19 06:46:04 UTC) #1
not at google - send to devlin
lgtm https://codereview.chromium.org/14348015/diff/1/chrome/browser/extensions/api/app_runtime/app_runtime_api.cc File chrome/browser/extensions/api/app_runtime/app_runtime_api.cc (right): https://codereview.chromium.org/14348015/diff/1/chrome/browser/extensions/api/app_runtime/app_runtime_api.cc#newcode40 chrome/browser/extensions/api/app_runtime/app_runtime_api.cc:40: extension_id); 1 line? https://codereview.chromium.org/14348015/diff/1/chrome/browser/extensions/api/app_runtime/app_runtime_api.cc#newcode45 chrome/browser/extensions/api/app_runtime/app_runtime_api.cc:45: extension_id); 1 line? ...
7 years, 8 months ago (2013-04-19 14:16:52 UTC) #2
koz (OOO until 15th September)
Thanks! https://codereview.chromium.org/14348015/diff/1/chrome/browser/extensions/api/app_runtime/app_runtime_api.cc File chrome/browser/extensions/api/app_runtime/app_runtime_api.cc (right): https://codereview.chromium.org/14348015/diff/1/chrome/browser/extensions/api/app_runtime/app_runtime_api.cc#newcode40 chrome/browser/extensions/api/app_runtime/app_runtime_api.cc:40: extension_id); On 2013/04/19 14:16:52, kalman wrote: > 1 ...
7 years, 8 months ago (2013-04-21 23:33:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/14348015/5001
7 years, 8 months ago (2013-04-21 23:33:16 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-21 23:36:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/14348015/17001
7 years, 8 months ago (2013-04-22 00:05:43 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, cacheinvalidation_unittests, chromedriver2_unittests, components_unittests, content_browsertests, ...
7 years, 8 months ago (2013-04-22 01:12:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/14348015/17001
7 years, 8 months ago (2013-04-22 01:45:34 UTC) #8
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, cacheinvalidation_unittests, chromedriver2_unittests, components_unittests, content_browsertests, ...
7 years, 8 months ago (2013-04-22 03:00:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/14348015/17001
7 years, 8 months ago (2013-04-23 00:13:06 UTC) #10
commit-bot: I haz the power
7 years, 8 months ago (2013-04-23 03:06:16 UTC) #11
Message was sent while issue was closed.
Change committed as 195698

Powered by Google App Engine
This is Rietveld 408576698