[SPDY] Close SPDY sessions on session flow control errors

tools/metrics/histograms/histograms.xml

 <!--
 Copyright 2013 The Chromium Authors. All rights reserved.
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 -->
 
 <!--
 This file is used to generate a comprehensive list of Chrome histograms along
 with a detailed description for each histogram.
 
@@ skipping 4743 matching lines @@
   <int value="709" label="PKCS12_IMPORT_UNSUPPORTED"/>
   <int value="710" label="KEY_GENERATION_FAILED"/>
   <int value="711" label="ORIGIN_BOUND_CERT_GENERATION_FAILED"/>
   <int value="712" label="PRIVATE_KEY_EXPORT_FAILED"/>
   <int value="800" label="DNS_MALFORMED_RESPONSE"/>
   <int value="801" label="DNS_SERVER_REQUIRES_TCP"/>
   <int value="802" label="DNS_SERVER_FAILED"/>
   <int value="803" label="DNS_TIMED_OUT"/>
   <int value="804" label="DNS_CACHE_MISS"/>
   <int value="805" label="DNS_SEARCH_EMPTY"/>
+  <int value="806" label="DNS_SORT_ERROR"/>
 </enum>
 
 <enum name="NetPreconnectUtilization" type="int">
   <int value="0" label="non-speculative, never connected"/>
   <int value="1" label="non-speculative, never used"/>
   <int value="2" label="non-speculative and used"/>
   <int value="3" label="omnibox never connected"/>
   <int value="4" label="omnibox never used"/>
   <int value="5" label="omnibox and used"/>
   <int value="6" label="subresource never connected"/>
@@ skipping 289 matching lines @@
   <int value="1" label="ws"/>
   <int value="2" label="wss"/>
 </enum>
 
 <enum name="SpdyIPPoolDomainMatch" type="int">
   <int value="0" label="mismatch"/>
   <int value="1" label="match"/>
 </enum>
 
 <enum name="SpdyProtocolErrorDetails" type="int">
+<!-- SpdyFramer::SpdyErrors -->

[jar (doing other things), 2013/04/19 06:16:11]

nit: I *think* these comments will be removed during the pretty-print run, which
will also alphabetize etc.

[akalin, 2013/04/19 08:46:24]

Nope, they were kept.

+
   <int value="0" label="No error"/>
   <int value="1" label="Invalid Control Frame"/>
   <int value="2" label="Control Frame Payload Too Large"/>
   <int value="3" label="Zlib Init Failure"/>
   <int value="4" label="Unsupported Version"/>
   <int value="5" label="Decompress Failure"/>
   <int value="6" label="Compress Failure"/>
   <int value="7" label="Credential Frame Corrupt"/>
   <int value="8" label="Invalid Data Frame Flags"/>
-  <int value="9" label="Invalid Status Code"/>
-  <int value="10" label="Protocol Error"/>
-  <int value="11" label="Invalid Stream"/>
-  <int value="12" label="Refused Stream"/>
-  <int value="13" label="Unsupported Version"/>
-  <int value="14" label="Cancel"/>
-  <int value="15" label="Internal Error"/>
-  <int value="16" label="Flow Control Error"/>
-  <int value="17" label="Stream In Use"/>
-  <int value="18" label="Stream Already Closed"/>
-  <int value="19" label="Invalid Credentials"/>
-  <int value="20" label="Frame Too Large"/>
-  <int value="21" label="Unexpected Ping"/>
-  <int value="22" label="Rst Stream For Non Active Stream"/>
-  <int value="23" label="Spdy Compression Failure"/>
-  <int value="24" label="Request For Secure Content Over Insecure Session"/>
-  <int value="25" label="Protocol Error Syn Reply Not Received"/>
-  <int value="26" label="Num Spdy Protocol Error Details"/>
+  <int value="9" label="Invalid Control Frame Flags"/>
+<!-- SpdyRstStreamStatus -->
+
+  <int value="10" label="(Unused)"/>
+  <int value="11" label="Protocol Error"/>

[jar (doing other things), 2013/04/19 06:16:11]

Usually, when the enums change, best practice is to define a new enum, and at
most, obsolete the old enums (and perhasp the histograms that use the old
enums).

...unless of course the enums were already/always wrong.

If you just change the enums, then all the old histogram data will appear
corrupt and confused :-(.  Since there are generally lots of recent/older
versions sending in UMA data, this tends to lead to a lot of confusion.

[akalin, 2013/04/19 08:46:24]

Done. Looks like I inadvertently changed the enums in a previous CL. :( So I
defined a new enum and new histograms and added various comments.

+  <int value="12" label="Invalid Stream"/>
+  <int value="13" label="Refused Stream"/>
+  <int value="14" label="Unsupported Version"/>
+  <int value="15" label="Cancel"/>
+  <int value="16" label="Internal Error"/>
+  <int value="17" label="Flow Control Error"/>
+  <int value="18" label="Stream In Use"/>
+  <int value="19" label="Stream Already Closed"/>
+  <int value="20" label="Invalid Credentials"/>
+  <int value="21" label="Frame Too Large"/>
+<!-- SpdySession errors -->
+
+  <int value="22" label="Unexpected Ping"/>
+  <int value="23" label="Rst Stream For Non Active Stream"/>
+  <int value="24" label="Spdy Compression Failure"/>
+  <int value="25" label="Request For Secure Content Over Insecure Session"/>
+  <int value="26" label="Syn Reply Not Received"/>
+  <int value="27" label="Invalid Window Update Size"/>
+  <int value="28" label="Receive Window Size Violation"/>
+  <int value="29" label="(Unused)"/>
 </enum>
 
 <enum name="SpdySessionGet" type="int">
   <int value="0" label="created new"/>
   <int value="1" label="found existing"/>
   <int value="2" label="found existing from IP Pool"/>
   <int value="3" label="imported from socket"/>
 </enum>
 
 <enum name="SpdySettingsReceived" type="int">
@@ skipping 490 matching lines @@
 <fieldtrial name="SSLResumption">
   <group name="Resume_Handshake" label="Session Resumption"/>
   <group name="Full_Handshake" label="Full"/>
   <affected-histogram name="Net.SSL_Connection_Latency"/>
   <affected-histogram name="Net.SSL_Connection_Latency_Google"/>
 </fieldtrial>
 
 </fieldtrials>
 
 </histogram-configuration>