Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Issue 14348011: Add a unit test for BrowserViewLayout (Closed)

Created:
7 years, 8 months ago by James Cook
Modified:
7 years, 8 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Add a unit test for BrowserViewLayout This is the first of several steps. * Decouple Browser and BrowserView initialization * Dependency inject Browser into BrowserViewLayout * Modify BrowserWithTestWindowTest to allow it to use a BrowserView as its BrowserWindow * Add some trivial assertions BUG=233374 TEST=added unit_tests BrowserViewLayout.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195301

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -27 lines) Patch
M chrome/browser/ui/views/frame/browser_view.h View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 6 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.h View 5 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.cc View 3 chunks +4 lines, -11 lines 0 comments Download
A chrome/browser/ui/views/frame/browser_view_layout_unittest.cc View 1 chunk +58 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.h View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
James Cook
Ben, PTAL. I'd like to get some early feedback on my approach here. I made ...
7 years, 8 months ago (2013-04-19 03:07:38 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 8 months ago (2013-04-19 16:19:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/14348011/1
7 years, 8 months ago (2013-04-19 18:39:33 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=137002
7 years, 8 months ago (2013-04-19 20:08:00 UTC) #4
James Cook
7 years, 8 months ago (2013-04-19 22:00:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r195301 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698