Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 14348002: Remove SCons related files (Closed)

Created:
7 years, 8 months ago by Jakob Kummerow
Modified:
7 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, tfarina
Visibility:
Public.

Description

Remove SCons related files Committed: http://code.google.com/p/v8/source/detail?r=14328

Patch Set 1 #

Patch Set 2 : fixed os.path.join occurrences that depended on old imports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4774 lines) Patch
D SConstruct View 1 chunk +0 lines, -1612 lines 0 comments Download
D preparser/SConscript View 1 chunk +0 lines, -38 lines 0 comments Download
D samples/SConscript View 1 chunk +0 lines, -38 lines 0 comments Download
D src/SConscript View 1 chunk +0 lines, -413 lines 0 comments Download
D test/cctest/SConscript View 1 chunk +0 lines, -152 lines 0 comments Download
M test/cctest/testcfg.py View 1 chunk +0 lines, -97 lines 0 comments Download
M test/message/testcfg.py View 1 2 chunks +1 line, -114 lines 0 comments Download
M test/mjsunit/testcfg.py View 1 2 chunks +1 line, -132 lines 0 comments Download
M test/mozilla/testcfg.py View 1 3 chunks +2 lines, -95 lines 0 comments Download
M test/preparser/testcfg.py View 1 3 chunks +2 lines, -142 lines 0 comments Download
M test/test262/testcfg.py View 1 chunk +0 lines, -112 lines 0 comments Download
D tools/test.py View 1 chunk +0 lines, -1559 lines 0 comments Download
D tools/test-wrapper-gypbuild.py View 1 chunk +0 lines, -270 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
LGTM.
7 years, 8 months ago (2013-04-18 10:55:25 UTC) #1
Jakob Kummerow
Committed patchset #2 manually as r14328 (presubmit successful).
7 years, 8 months ago (2013-04-18 11:01:26 UTC) #2
tfarina
thanks!
7 years, 8 months ago (2013-04-18 11:38:37 UTC) #3
Jakob Kummerow
7 years, 8 months ago (2013-04-18 11:41:25 UTC) #4
Message was sent while issue was closed.
It only took two years to get from the decision to kill off the SCons build to
this CL.

Powered by Google App Engine
This is Rietveld 408576698